Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude expired badges #9

Open
jamesgeddes opened this issue Dec 15, 2023 · 1 comment
Open

exclude expired badges #9

jamesgeddes opened this issue Dec 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jamesgeddes
Copy link

Add the option to exclude expired badges

For example, I have two Terraform badges, 002 which is expired, and 003 which is (at the time of writing) current. I would want to be able to exclude the expired one.

Suggested solution

Add exclude input.

- uses: michaelcontento/credly-import-action@v1
  with:
    # The user of whom we want to grab the infos
    name: michael-contento
    exclude:
      expired: true

If exclude.expired == "true" and if expires_at ≤ time.now, then pass.

Future improvement

Making this a general exclusions input would also provide forward compatibility to potentially add other exclusions in a subsequent ticket. For example;

- uses: michaelcontento/credly-import-action@v1
  with:
    # The user of whom we want to grab the infos
    name: michael-contento
    exclude:
      expired: true
      issuers:
        - IBM
        - Coursera
      cost: Free

Assignee

I will gladly do this if you want to assign it to me.

@michaelcontento
Copy link
Owner

Hi @jamesgeddes 👋

I really like your idea, but my personal time is quite contraint this month. But if you want, feel free to send me a PR 🤘 🚀

@michaelcontento michaelcontento added the enhancement New feature or request label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants