Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current GIT master (=0.9.2) build failing in Debian Stretch #27

Closed
trebmuh opened this issue Oct 11, 2018 · 8 comments
Closed

current GIT master (=0.9.2) build failing in Debian Stretch #27

trebmuh opened this issue Oct 11, 2018 · 8 comments

Comments

@trebmuh
Copy link
Contributor

trebmuh commented Oct 11, 2018

Hi, I've tried compiling on a Debian Stretch from current git master which is the same at the time of writing than 0.9.2.

The build fails with:
...

                                              ^
DragonflyReverbUI.cpp:64:108: warning: ISO C++ forbids converting a string constant to ‘char*’ [-Wwrite-strings]
 dKnob (this, this, &fNanoText, paramLowMult,   "%2.1f X",  knobx[3], knoby[2]);
                                                                              ^
DragonflyReverbUI.cpp: At global scope:
DragonflyReverbUI.cpp:201:74: error: virt-specifiers in ‘stateChanged’ not allowed outside a class definition
 id DragonflyReverbUI::stateChanged(const char* key, const char* value) override
                                                                        ^~~~~~~~
DragonflyReverbUI.cpp: In member function ‘virtual void DISTRHO::DragonflyReverbUI::onDisplay()’:
DragonflyReverbUI.cpp:346:9: warning: unused variable ‘xstart’ [-Wunused-variable]
   float xstart = 20.0f, ystart= 92.0f;
         ^~~~~~

...
Please, let me know if you need some more information.

@michaelwillis
Copy link
Owner

@trebmuh I fixed the problem with override this morning.

Which compiler version are you using? It worked for me, but admittedly I did get compiler warnings about conflating string literals and char*, so I will try to fix that soon.

@trebmuh
Copy link
Contributor Author

trebmuh commented Oct 11, 2018

gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516

@michaelwillis
Copy link
Owner

It seems like this is the correct solution: https://stackoverflow.com/a/1531673

I will try to fix this soon, or you are welcome to try if you want.

@trebmuh
Copy link
Contributor Author

trebmuh commented Oct 11, 2018

Thanks for your quick answer.
Unfortunately, that's far beyond my skills (I'm not a coder at all), then I'll wait for your fix.
Please, feel free to ping me and I'll test it.

@michaelwillis
Copy link
Owner

@trebmuh Please try again, I hope it will work as of 8465d10

@michaelwillis
Copy link
Owner

@trebmuh I have now had two other Linux users report that it is now working on different distros.

@trebmuh
Copy link
Contributor Author

trebmuh commented Oct 12, 2018

I'll try it and report back here in the few hours coming (need to finish some other stuffs first).

@trebmuh
Copy link
Contributor Author

trebmuh commented Oct 12, 2018

@michaelwillis just did it, and it compiles fine. Tested it a bit, and it does look to me that it's working as expected. Thank you for the quick fix!
Closing then.

@trebmuh trebmuh closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants