Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault with Python version #13

Closed
GoogleCodeExporter opened this issue Nov 21, 2015 · 3 comments
Closed

Segfault with Python version #13

GoogleCodeExporter opened this issue Nov 21, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link


Following input makes Python version segfault:

points = [
    [2.10229524019, -0.760509508136],
    [2.15571376911, -0.752653842118],
    [2.00173917352, 0.294373407871],
    [1.9483206446, 0.286517741853]
]
holes = [[
    [1.9968142935, 0.0247609293562],
    [2.02104796235, 0.0283247041864],
    [2.08803526014, -0.495188920808],
    [2.06380159129, -0.498752695638]
]]

one edge of the hole is very close to contour. I'm not sure whether this input 
is correct but it should not segfault.

Original issue reported on code.google.com by dusan.ma...@gmail.com on 2 Dec 2010 at 11:51

@GoogleCodeExporter
Copy link
Author

Sorry for the late reply.

I tested the input on the java version, tho it didn't crash the hole can't be 
handled because one point seems to be on the edge of the polygon or close 
enough to be considered on the edge. 

I have forwarded this issue to the maintainer of the Python port.

Original comment by thahlen@gmail.com on 13 Dec 2010 at 11:03

@GoogleCodeExporter
Copy link
Author

Thomas is correct; one point in the hole is close enough to the edge of the 
polygon to be considered on the edge. Holes need to be contained "inside" their 
respective polygons! 

FYI, this point set does not make the C++ version crash.... but it returns an 
incorrect result because of the invalid input; attached is a screenshot.


Original comment by mason.gr...@gmail.com on 15 Dec 2010 at 4:26

Attachments:

@GoogleCodeExporter
Copy link
Author

Closed!

Original comment by mason.gr...@gmail.com on 15 Dec 2010 at 5:50

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant