links breaking after adding a new note via ZkNew

[nathanbraun]

Not sure if this is an zk-nvim or zk issue, but...

On initial db creation (if I delete notebook.db, then do zk index) all the links work fine. I can look at it in my db GUI and everything looks good.

However, if I add a new note using :ZkNew, all the values of target_id in the links table of notebook.db get updated to whatever the new note's ID is.

Everything goes back to working if I delete notebook.db then regenerate it, but that's obviously tedious to do. Note adding a link seems to work fine, it's just creating a new note that is causing issues.

[mickael-menu]

Hum that's really weird. Would you mind giving detailed steps to reproduce this issue? Which ZkNew you run and maybe a sample zk notebook, as well as which versions of zk and zk-nvim you're using. Thanks.

[nathanbraun]

I made a repo illustrating it:

https://github.com/nathanbraun/zk-test

I started out with 3 notes (main branch of referenced repo). Screenshot of links:

Then I added a note (calling <Cmd>ZkNew<CR>, which I've mapped to <leader>zn). That note gets the id 4 and turns the links to this:

I added that note in the add-note branch so you can see that too.

My zk version is: zk HEAD-68e6b70. I just installed zk-nvim a few days ago, and believe that's the latest version too. Note I am using it with vimwiki + a custom template, different file extension etc.

[mickael-menu]

Thank you, I can reproduce the problem. The issue happens with zk new too, I'm moving the issue to the other repo.

[mickael-menu]

@nathanbraun https://github.com/mickael-menu/zk/pull/237 (branch issue-62) should fix this issue, but I would appreciate if you could double check before I merge it. Thanks!

[nathanbraun]

@nathanbraun #237 (branch issue-62) should fix this issue, but I would appreciate if you could double check before I merge it. Thanks!

Just tried it and it's working for me! Thank you!

[nathanbraun]

Closed, but on second thought will let you close it when it's merged. Looked good though