Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Deprecate title matching for wiki links #218

Merged
merged 2 commits into from
May 22, 2022
Merged

LSP: Deprecate title matching for wiki links #218

merged 2 commits into from
May 22, 2022

Conversation

mickael-menu
Copy link
Member

Deprecated

  • The LSP server does not support resolving a wiki link to a note title anymore.
    • For example, [[Planet]] can match a note with filename i4w0 Planet.md but not i4w0.md with a Markdown title Planet anymore.
    • This "smart" fallback resolution based on note titles was too fragile and not supported by the zk CLI.

@mickael-menu mickael-menu force-pushed the fix/deprecate-title-wiki-matching branch from 0405e81 to a22943f Compare May 22, 2022 20:54
@mickael-menu mickael-menu merged commit 1a05a04 into main May 22, 2022
@mickael-menu mickael-menu deleted the fix/deprecate-title-wiki-matching branch May 22, 2022 21:08
@mickael-menu mickael-menu mentioned this pull request Sep 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mickael-menu