Include get-date helper function

[zalegrala]

No description provided.

[mickael-menu]

Thank you! Would you mind adding some unit tests for this new helper? You can find examples here: https://github.com/mickael-menu/zk/blob/c21c4fc21f7fe75f05d3fc3d09e74ffed41ba2ef/internal/adapter/handlebars/handlebars_test.go#L229

[zalegrala]

Nice, thanks for the review. I'll find some time this week to add tests and address your feedback.

[zalegrala]

I've added a couple tests. Let me know if you'd like me to drop the date calls in the get-date tests. I added them because I mentioned them in the function docs, so thought it was worth leaving in.

[mickael-menu]

I've added a couple tests. Let me know if you'd like me to drop the date calls in the get-date tests.
No that's great, thank you.

I think the tests are failing because the helper is using time.Now() in the implementation, so the now context var set in the tests is ignored.

To work around this, and after fixing my other comment to use TimeFromNatural(), you can use an absolute date as input (e.g. {{get-date "2006-01-02T15:04:05"}} instead of a relative one. We just need to test that TimeFromNatural() is called, and can assume that relative dates will work as well.

[mickael-menu]

Sorry I missed this in my first review, but you can use the helper TimeFromNatural() (which is part of this project) instead of using directly naturaldate.Parse(). This way it will be able to parse more formats.

[zalegrala]

Okay, I've updated. As a side note, I had to add exclude github.com/mattn/go-sqlite3 v2.0.3+incompatible to the go.mod in order to test locally. Looks like some chatter here about it. mattn/go-sqlite3#975

[mickael-menu]

@zalegrala Thank you for contributing this feature!

I might change the names before the next release, I'll sleep on it:

• {{date}} -> {{format-date}}
• {{get-date}} -> {{date}}

[mickael-menu]

I released a new version and renamed the date helpers.