Add notebook configuration to set default notebook path
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickael-menu
reviewed
Apr 3, 2023
There was a problem hiding this comment.
I'm uncomfortable authorizing a notebook.dir config key in all config.toml files, because it wouldn't make sense (and could be incorrect) in the config.toml embedded inside a notebook (.zk/config.toml).
Would you mind updating your PR to only parse such key in the global config file? Maybe outputting an error if notebook.dir is set inside a "local" config.toml.
|
Hey @mickael-menu is there anything else left for me to do here? |
|
Sorry, I didn't receive any GitHub notification. I'll take a look. |
mickael-menu
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on #300.
This is the proposed solution to add the default notebook path on the
config.toml.