Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are changes from nuttx mainline merged into this fork? #51

Open
cmorganBE opened this issue Apr 22, 2020 · 3 comments
Open

How are changes from nuttx mainline merged into this fork? #51

cmorganBE opened this issue Apr 22, 2020 · 3 comments

Comments

@cmorganBE
Copy link

Hello! I'm looking to use micro-ROS on a mcu with our ros2 system. I've run into a couple of issues that thankfully only took a few minutes to identify the cause of, that turned out to have been fixed in early 2019 on nuttx mainline. What approaches are used to keep in sync with nuttx mainline? I'll gladly open PRs and pull over the commits that resolve, I'm more interested in the overall approach to keeping things in sync and avoiding time spent fixing issues already fixed in mainline.

Regards,
Chris

@jfm92
Copy link
Contributor

jfm92 commented Apr 22, 2020

Hi Chris,

First of all, thanks for being interested in micro-ROS!
Regarding synchronization with the NuttX mainline, we schedule a rebase with the mainline repo every 6 months. But this schedule was a little delayed because now we support three different RTOS.
So, we're planning to perform a rebase to version 8.2 on the next months, but if you want to do a PR, we will highly appreciate!

Regards,
Juan

@cmorganBE
Copy link
Author

Hi @jfm92. Thank you for the response. Let me look at a rebase against nuttx mainline as an initial step. Imo that would be a more complete effort than cherry picking a few fixes while potentially leaving a lot more behind.

Would you mind if I opened a PR against the website to document the rebase approach and normal schedule?

What kinds of tests would/should I run when doing that rebase before opening up a pr?

@FranFin
Copy link

FranFin commented Jul 20, 2020

@cmorganBE Hi! Thank you for your interest in micro-ROS. Notice that we’ll discuss the recent contributions and developments in the next Embedded WG meeting. You’re invited to bring your micro-ROS related issue to this platform. We’ll be very happy to have you join us and discuss your questions with the community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants