New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Teensy 4.1 mac address getter to Ethernet publisher example #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Kamath <adityakamath@live.com>
pablogs9
approved these changes
Jul 11, 2022
@mergify backport foxy main humble |
🟠 Waiting for conditions to match
|
pablogs9
reviewed
Jul 11, 2022
examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino
Outdated
Show resolved
Hide resolved
…rnet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
@Acuadros95 please review |
Acuadros95
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
) * Added Teensy 4.1 mac address getter to Ethernet publisher example Signed-off-by: Aditya Kamath <adityakamath@live.com> * Update examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 48833b3)
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
) * Added Teensy 4.1 mac address getter to Ethernet publisher example Signed-off-by: Aditya Kamath <adityakamath@live.com> * Update examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 48833b3)
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
) * Added Teensy 4.1 mac address getter to Ethernet publisher example Signed-off-by: Aditya Kamath <adityakamath@live.com> * Update examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 48833b3)
✅ Backports have been created
|
pablogs9
pushed a commit
that referenced
this pull request
Jul 12, 2022
) (#1077) * Added Teensy 4.1 mac address getter to Ethernet publisher example Signed-off-by: Aditya Kamath <adityakamath@live.com> * Update examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 48833b3) Co-authored-by: Aditya Kamath <adityakamath@live.com>
pablogs9
pushed a commit
that referenced
this pull request
Jul 12, 2022
) (#1078) * Added Teensy 4.1 mac address getter to Ethernet publisher example Signed-off-by: Aditya Kamath <adityakamath@live.com> * Update examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 48833b3) Co-authored-by: Aditya Kamath <adityakamath@live.com>
pablogs9
pushed a commit
that referenced
this pull request
Jul 12, 2022
) (#1079) * Added Teensy 4.1 mac address getter to Ethernet publisher example Signed-off-by: Aditya Kamath <adityakamath@live.com> * Update examples/micro-ros_publisher_ethernet/micro-ros_publisher_ethernet.ino Co-authored-by: Pablo Garrido <pablogs9@gmail.com> Co-authored-by: Pablo Garrido <pablogs9@gmail.com> (cherry picked from commit 48833b3) Co-authored-by: Aditya Kamath <adityakamath@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya Kamath adityakamath@live.com