Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FindPython3 explicitly instead of FindPythonInterp implicitly #34

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 12, 2021

These packages were using PYTHON_EXECUTABLE, but weren't find_package()ing FindPythonInterp. Upstream PRs ros2/rosidl#612 and ament/ament_cmake#355 removed two uses of PythonInterp. This PR makes it use Python3::Interpreter from FindPython3 because CMake 3.12 deprecates FindPythonInterp.

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@pablogs9
Copy link
Member

Thanks a lot for this PR @sloretz!

@codecov-commenter
Copy link

Codecov Report

Merging #34 (d28b558) into main (2ad69f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #34   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines          9       9           
  Branches       2       2           
=====================================
  Misses         9       9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad69f9...d28b558. Read the comment docs.

@pablogs9 pablogs9 merged commit 7efacee into micro-ROS:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants