Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributors list #601

Closed
TuomasBorman opened this issue Jul 10, 2024 · 6 comments
Closed

Update contributors list #601

TuomasBorman opened this issue Jul 10, 2024 · 6 comments
Assignees
@ake123

Comments

@TuomasBorman
Copy link
Contributor

Check that contributor list in DESCRIPTION is up-to-date (https://github.com/microbiome/mia/graphs/contributors). Do the same in miaViz and OMA.

At least these are missing in mia:
@TuomasBorman
Copy link
Contributor Author

For the future, remember to update contributor list when the contributor contributes first time (now it might be easier, when all the missing contributors are from our team)

@TuomasBorman
Copy link
Contributor Author

Would you be able @ake123 to do PR?

@ake123
Copy link
Collaborator

ake123 commented Jul 10, 2024

Yes sure I will make the changes and make PR

ake123 added a commit to ake123/mia that referenced this issue Jul 10, 2024
@ake123
microbiome#601 and OMA #482
10ebc25
@ake123 ake123 mentioned this issue Jul 10, 2024
Merged
@antagomir
Copy link
Member

Can you also close this issue when the PR is ready?

@antagomir
Copy link
Member

@ake123 ?

@ake123
Copy link
Collaborator

ake123 commented Jul 24, 2024

PR is ready!

@ake123 ake123 closed this as completed Jul 24, 2024
TuomasBorman added a commit that referenced this issue Jul 30, 2024
@ake123 @TuomasBorman @antagomir
#601 and OMA issue #482 (#602)
b75207a 
Co-authored-by: Tuomas Borman <60338854+TuomasBorman@users.noreply.github.com>
Co-authored-by: Leo Lahti <leo.lahti@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ake123 ake123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antagomir @ake123 @TuomasBorman