-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace getExperiment* and testExperiment* functions with getCrossAssociation #511
Conversation
deprecate getExperimentCrossAssociation deprecate getExperimentCrossCorrelation deprecate testExperimentCrossAssociation deprecate testExperimentCrossCorrelation
Merge branch 'devel' of https://github.com/microbiome/mia into getCrossAssociation # Conflicts: # man/deprecate.Rd
Looks good, the idea of this PR was to remove additional functions that we have only one function for cross-correlation. Moreover, the name of function was shortened |
test_significance could still be FALSE by default. The function uses base (or stats) R by default for calculating cross-correlation. The function that calculates correlation without significance testing is much faster |
Merge branch 'devel' of https://github.com/microbiome/mia into getCrossAssociation # Conflicts: # R/deprecate.R # man/deprecate.Rd
Some conflicts..? |
Otherwise seems fine |
Merge branch 'devel' of https://github.com/microbiome/mia into getCrossAssociation # Conflicts: # DESCRIPTION # NEWS # R/deprecate.R # man/deprecate.Rd # pkgdown/_pkgdown.yml
Create new function
getCrossAssociation
to replace the following :New function
getCrossAssociation
makes the significance test as default(test_significance
default value isTRUE
)