Replace getExperiment* and testExperiment* functions with getCrossAssociation #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecate getExperimentCrossAssociation deprecate getExperimentCrossCorrelation deprecate testExperimentCrossAssociation deprecate testExperimentCrossCorrelation
Merge branch 'devel' of https://github.com/microbiome/mia into getCrossAssociation # Conflicts: # man/deprecate.Rd
|
Looks good, the idea of this PR was to remove additional functions that we have only one function for cross-correlation. Moreover, the name of function was shortened |
|
test_significance could still be FALSE by default. The function uses base (or stats) R by default for calculating cross-correlation. The function that calculates correlation without significance testing is much faster |
Merge branch 'devel' of https://github.com/microbiome/mia into getCrossAssociation # Conflicts: # R/deprecate.R # man/deprecate.Rd
TuomasBorman
approved these changes
May 5, 2024
|
Some conflicts..? |
|
Otherwise seems fine |
Merge branch 'devel' of https://github.com/microbiome/mia into getCrossAssociation # Conflicts: # DESCRIPTION # NEWS # R/deprecate.R # man/deprecate.Rd # pkgdown/_pkgdown.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new function
getCrossAssociationto replace the following :New function
getCrossAssociationmakes the significance test as default(test_significancedefault value isTRUE)