Make extraction_target slot multivalued and implement migrator
#192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheal
changed the title
kheal
changed the title
extraction_target slot multivalued and implement migrator
brynnz22
approved these changes
Jun 5, 2024
|
|
||
| class Migrator(MigratorBase): | ||
| """ | ||
| Migrates data from X to PR192, makes the existing extracion_target slot multivalued and change its name to extraction_targets |
There was a problem hiding this comment.
extraction is spelled like extracion
|
There is one little typo, but otherwise I tested and the migrator works! |
turbomam
approved these changes
Jun 5, 2024
|
Thanks for implementing this and reviewing this. The migrator looks good to me. I approve, too (retroactively). |
|
Hi @kheal, will you add this migrator (a link to this PR) to the appropriate position in the description (i.e. first comment) of the "meta-issue" at microbiomedata#1607 (comment)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue microbiomedata#2043
The following changes were made here:
extraction_targettoextraction_targetsextraction_targetsslot multivalued