Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ExtractionTarget mutlivalued to accommodate MPLEX extractions #2043

Closed
4 tasks
brynnz22 opened this issue Jun 5, 2024 · 1 comment
Closed
4 tasks

Make ExtractionTarget mutlivalued to accommodate MPLEX extractions #2043

brynnz22 opened this issue Jun 5, 2024 · 1 comment
Assignees
@kheal @brynnz22

Comments

@brynnz22
Copy link
Contributor

brynnz22 commented Jun 5, 2024

extraction_target needs to accomodate multiple extraction targets for protocols like MPLEX and MPLEX-lite that have extraction targets of metabolite lipid and protein. Need to:

  • change name of slot to extraction_targets because it is multivalued
  • make extraction_target multivalued
  • Add lipid to extractionTargetEnum
  • Write migrator to accommodate the multivalued change and the slot name change.
This was referenced Jun 5, 2024
Closed
Merged
@anastasiyaprymolenna anastasiyaprymolenna mentioned this issue Jun 5, 2024
Open
@turbomam
Copy link
Collaborator

turbomam commented Jun 6, 2024

A PR has been merged for this issue. Should it still be left open?

@kheal kheal closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kheal kheal

@brynnz22 brynnz22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kheal @turbomam @brynnz22