Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render Mappings section generally on all element documentation pages #2087

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sujaypatil96
Copy link
Collaborator

Analogous to linkml/linkml#2172

Copy link

github-actions bot commented Jun 25, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2087/
on branch gh-pages at 2024-07-11 16:56 UTC

@sujaypatil96 sujaypatil96 marked this pull request as draft June 25, 2024 20:20
@sujaypatil96
Copy link
Collaborator Author

Converting this PR to draft because the GitHub Action workflow needs to be fixed in linkml-project-cookiecutter and then the changes need to be applied here: https://github.com/linkml/linkml-project-cookiecutter/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/test_pages_build.yaml to keep both of them in sync

@sujaypatil96 sujaypatil96 marked this pull request as ready for review July 11, 2024 16:54
Copy link
Collaborator

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't change schema but does improve understand-ability of the schema through the documentation. I recommend merging into both schema now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants