Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add person/profile_image #68

Merged
merged 12 commits into from
Jun 17, 2021
Merged

add person/profile_image #68

merged 12 commits into from
Jun 17, 2021

Conversation

dwinston
Copy link
Collaborator

related to #19. cc @dehays

  • move data object class to core.yaml
  • add profile image slot to person value, with a range of data object (which has a url).

@dwinston dwinston requested a review from wdduncan June 15, 2021 18:44
@dwinston
Copy link
Collaborator Author

@wdduncan what's the difference between the person and person value classes in core.yaml? Did I use the right one here?

src/schema/core.yaml Outdated Show resolved Hide resolved
@wdduncan wdduncan changed the title add person/profile_image; move data object to core add person/profile_image Jun 17, 2021
@wdduncan wdduncan merged commit e78d983 into main Jun 17, 2021
@wdduncan wdduncan deleted the person-profile-image branch June 17, 2021 20:58
turbomam pushed a commit that referenced this pull request Feb 21, 2024
Added invalid example file to show compound appropraite/inappropriate values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants