Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnifiedNlp is not registered in system on Android 4.1 #104

Closed
ale5000-git opened this issue Dec 8, 2016 · 13 comments
Closed

UnifiedNlp is not registered in system on Android 4.1 #104

ale5000-git opened this issue Dec 8, 2016 · 13 comments

Comments

@ale5000-git
Copy link
Member

ale5000-git commented Dec 8, 2016

Quote from mandayugana's post to keep track of the problem.

Currently I'm using Samsung 4.1.2 firmware. I have successfully removed Google and Samsung apps from system. But I have an issue that UnifiedNlp is not registered in system. It is finally registered after adding the third line into Manifest.xml.

        <service android:exported="true" android:name="org.microg.nlp.location.LocationServiceV1" android:permission="android.permission.ACCESS_COARSE_LOCATION">
            <intent-filter>
		<action android:name="com.android.location.service.NetworkLocationProvider"/>
                <action android:name="com.google.android.location.NetworkLocationProvider"/>
            </intent-filter>
            <meta-data android:name="serviceVersion" android:value="1"/>
            <meta-data android:name="version" android:value="1"/>
        </service>
@ghost
Copy link

ghost commented Dec 9, 2016

Can confirm that this occurs on Cyanogenmod 14.1 (nightly 2016-12-08)

@fw190
Copy link

fw190 commented Dec 10, 2016

I can confirm. Nexus 4 cyanogenmod 14.1 nightly 2016-12-10

@mar-v-in
Copy link
Member

CM14.1 is a different problem. Android 7.0 no longer supports NLP overlays not shipped with the ROM. There is a patch in the /patches/ folder of this repo that has to be applied to CM first.

@fw190
Copy link

fw190 commented Dec 11, 2016

How can I apply this patch? Should I flash it with TWRP?

@mar-v-in
Copy link
Member

It's a source code patch that has to be applied by the CM team. Afaik, there is no tool allowing to patch a system after installation so far (but it might be that there will be one sometime). Alternatively you can of course ask CM team to include the patch so that future versions of CM work out of the box.

@fw190
Copy link

fw190 commented Dec 12, 2016

I have asked at xda and at their forums. Could the patch creator make a pull request?

@Roxxor91
Copy link

I agree. The patch already exist, so it would be nice if we could try to have this integrated into CM. (If the CM team approves)
@danielegobbetti
As you are the original author, would you mind making a pull request? Or if you dont feel like it and allow me to, I could also try to do the request. Never did something like that and I am not a programmer, but I could try.

Off topic: Seems like you are everywhere, where I am (only more productive). MicroG, Gadgetbridge, FreeXperia, Conversations.. Thanks for helping making free software great!

@7lb
Copy link

7lb commented Dec 12, 2016

I'd also be willing to open a pull request if @danielegobbetti is unable or unwilling to do it.

I've forked the upstream branch and committed the patch (commit here) already, but I'm waiting for the author's permission before opening a pull request

@ale5000-git
Copy link
Member Author

ale5000-git commented Dec 12, 2016

I doubt they will accept it, since it have pro and contro.

PS: We are off-topic, the original problem isn't related to Android 7.x

@fw190
Copy link

fw190 commented Dec 12, 2016

@ale5000-git so where could we be on topic?

What do you mean with pro and contro?

What can we do to have gps without the need to install google apps? RIght now our phones doesn't have working gps.

@ale5000-git
Copy link
Member Author

@fw190: I suggest to open a separate issue.

The change limit location providers to only system apps, with the patch any app can become a location provider.
If you install UnifiedNlp in /system/priv-app/ then it will work even without the patch.

@danielegobbetti
Copy link
Contributor

danielegobbetti commented Dec 13, 2016

I'm not willing to interact with the ROM maintainers but feel free to do so and request that they include the patch. See my comment in the original issue: #102 (comment)

@mandayugana
Copy link

mandayugana commented Dec 15, 2016

Thanks, @ale5000-git, for bringing this issue here. UnifiedNlp is working fine on Omni Lollipop 5.1.1. This issue exists on JB 4.1.2. Installing UnifiedNlp as system app doesn't help.

@ale5000-git ale5000-git changed the title UnifiedNlp is not registered in system UnifiedNlp is not registered in system on Android 4.1 Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants
@danielegobbetti @mar-v-in @mandayugana @Roxxor91 @7lb @fw190 @ale5000-git and others