Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI? #13

Closed
igrr opened this issue Mar 12, 2018 · 8 comments
Closed

add CI? #13

igrr opened this issue Mar 12, 2018 · 8 comments

Comments

@igrr
Copy link
Contributor

igrr commented Mar 12, 2018

I can submit a PR to run some code ULP code through py-esp32-ulp and through binutils-esp32ulp, and compare the generated code, if you think this is useful.

@ThomasWaldmann
Copy link
Collaborator

Ah, yes, that would be very useful! For travis-ci or do you have sth else in mind?

(but note that the py-esp32-ulp assembler is not quite ready yet, but hopefully soon)

@ThomasWaldmann
Copy link
Collaborator

.S --> .ulp works now (the latter being the format with header expected by the loader).

Totally untested, but looking reasonable.

I made up that .ulp extension, what's the usual one?

@igrr
Copy link
Contributor Author

igrr commented Mar 13, 2018

Yes, i was thinking about adding a travis-ci script.

It's not going to fully work initially also because the binutils doesn't support SoC register addresses (like 0x3ff4-something) as arguments of reg_rd and reg_wr instructions. But that's something that's easy to add on binutils side of things, and looks like a nice feature.

The idea is to commit some simple tests first (which will pass in the current state of things) and add more tests as the features get added and compatibility improves.

Regarding file extension: IDF build process generates ulp binaries with .bin extension, which then get embedded into the firmware. The whole process is mostly invisible to the users, so i didn't put much thought into the extensions. .ulp is fine although i have to say that it may not be future proof. Future chips might be using different architecture for the ULP, so perhaps it would be better to indicate the chip model somehow (.ulp32? .esp32ulp? I don't know if extensions need to be 3 characters or not...)

@ThomasWaldmann
Copy link
Collaborator

Ideally it should be something the micropython filesystem can accept. Have to try that later.

CI plans sound good! :)

@ThomasWaldmann
Copy link
Collaborator

thanks for the PR, we have CI now! \o/

one small issue: the first 5000 lines of output are rather uninteresting (if binutils-esp32 and micropython build as usual), can we get them collapsed?

@igrr
Copy link
Contributor Author

igrr commented Mar 13, 2018

Sure, will wrap them into folds.

@ThomasWaldmann
Copy link
Collaborator

also please split the pure python stuff from the binutils stuff (creating 2 separate scripts to run them).

binutils-esp32 does not compile on my machine (bug reported), so I don't have that locally, so the one script does not work any more.

@ThomasWaldmann
Copy link
Collaborator

fixed by #23 and #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants