-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: RMT Neopixel implementation #4942
Comments
The Loboris port is known to have had some GPL code in it, so it would be too risky to have any code from there come into this repository. |
I can't comment on that other that all the relevant files have the MIT licence header and are marked to be written by himself. |
But it's hard to know if such code was/wasn't influenced by GPL code, if there's other GPL code around in the repository. In this case it's better to be cautious and consider his code to be unusable here. Since implementing an RMT driver is not that difficult it can be done for this repository as a fresh, clean implementation, and then there are no concerns about licensing. |
I didn't want to argue ;-) |
@carstenblt i'm new to micropython ecosystem, how did you integrate it in upstream? a simple copy paste where? any other files i need to modify? |
PewPew M4: use keypad instead of gamepad
Loboris has implemented a Neopixel driver in C using the ESP32 RMT interface.
https://github.com/loboris/MicroPython_ESP32_psRAM_LoBo/blob/master/MicroPython_BUILD/components/micropython/esp32/machine_neopixel.c
I have been using it because it is quite a bit faster when controlling a larger number of LEDs. It also offers some convenient functions to work with the HSB color space.
I have copied it to upstream micropython without any problems.
Are you willing to include this implementation? If yes, I would open a pull request. The question would then be how you would like to have it integrated:
The text was updated successfully, but these errors were encountered: