Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esp32/modesp32: Add temperature method for S2,C3 chips. #11672

Closed
wants to merge 6 commits into from
Closed

esp32/modesp32: Add temperature method for S2,C3 chips. #11672

wants to merge 6 commits into from

Conversation

ThinkTransit
Copy link
Sponsor Contributor

Provide access to temp_sensor_read_celsius() on S2/S3/C3 chips.

Signed-off-by: Patrick Joy patrick@joytech.com.au

@ThinkTransit ThinkTransit marked this pull request as ready for review May 31, 2023 13:47
@ThinkTransit
esp32/modesp32: Add temperature method for S2,C3 chips.
dd4d912 
Removed S3 as this is not available until idf>=4.4.2

Signed-off-by: Patrick Joy <patrick@joytech.com.au>
@ThinkTransit
Copy link
Sponsor Contributor Author

Support for S3 removed as this requires idf v4.4.2 or greater.

@ThinkTransit ThinkTransit changed the title esp32/modesp32: Add temperature method for S2,S3,C3 chips. esp32/modesp32: Add temperature method for S2,C3 chips. Jun 2, 2023
@ThinkTransit ThinkTransit force-pushed the esp32-temperature branch 2 times, most recently from c85eb81 to a67858c Compare June 2, 2023 10:02
@ThinkTransit
esp32/modesp32: Retrigger checks.
2029eac 
Signed-off-by: Patrick Joy <patrick@joytech.com.au>
@ThinkTransit
esp32/modesp32: Add temperature method for S2,C3 chips.
336f5d6 
Removed S3 as this is not available until idf>=4.4.2

Signed-off-by: Patrick Joy <patrick@joytech.com.au>
@ThinkTransit
esp32/modesp32: Add temperature method for S2,C3 chips.
f63b592 
Documentation changes.

Signed-off-by: Patrick Joy <patrick@joytech.com.au>
@dpgeorge
Copy link
Member

Now that the esp32 port uses IDF v5, it looks like this function has been deprecated.

Could you please update to use the new API temperature_sensor_get_celsius?

@ThinkTransit ThinkTransit force-pushed the esp32-temperature branch 2 times, most recently from f63b592 to 813d559 Compare June 27, 2023 12:40
@ThinkTransit
Copy link
Sponsor Contributor Author

ThinkTransit commented Jun 27, 2023 •
edited

Now that the esp32 port uses IDF v5, it looks like this function has been deprecated.

Could you please update to use the new API temperature_sensor_get_celsius?

Will do, I don't know why this PR decided to close itself so will need to reopen.

@ThinkTransit
Copy link
Sponsor Contributor Author

Reopening

@ThinkTransit ThinkTransit reopened this Jun 27, 2023
@ThinkTransit
esp32/modesp32: Updated to idf v5.0.2.
c1adfe5 
Signed-off-by: Patrick Joy <patrick@joytech.com.au>
@ThinkTransit
Copy link
Sponsor Contributor Author

@dpgeorge This has now been updated to use the new API. Tested on S2 and S3 modules, C3 compiles ok.

@Gadgetoid Gadgetoid mentioned this pull request Feb 29, 2024
Merged
@projectgus
Copy link
Contributor

This is an automated heads-up that we've just merged a Pull Request
that removes the STATIC macro from MicroPython's C API.

See #13763

A search suggests this PR might apply the STATIC macro to some C code. If it
does, then next time you rebase the PR (or merge from master) then you should
please replace all the STATIC keywords with static.

Although this is an automated message, feel free to @-reply to me directly if
you have any questions about this.

@dpgeorge
Copy link
Member

Sorry, this PR got lost, and it was superseded by the alternative implementation in 63c30a2 (which installs the temp sensor once).

@dpgeorge dpgeorge closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
port-esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThinkTransit @dpgeorge @projectgus