ports/rp2: Use MICROPY_BOARD_DIR to find pins.csv. #13766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not valid to assume that
${MICROPY_PORT_DIR}/boards/${MICROPY_BOARD}
is equal to${MICROPY_BOARD_DIR}
, because the latter could be outside of${MICROPY_PORT_DIR}
, eg: https://github.com/pimoroni/badger2040/tree/main/firmware/PIMORONI_BADGER2040WThis PR replaces this path with the canonical
${MICROPY_BOARD_DIR}
so thatpins.csv
is correctly located when building against out-of-tree board definitions.Additionally I've removed
MICROPY_BOARDS_DIR
to discourage similar mistakes.This bug caused
pins.csv
in our out-of-tree board definitions for Badger 2040W to not be detected- pimoroni/badger2040#60