Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unix: toggle for fatfs, since djgpp/freedos does not support this #1956

Closed
wants to merge 1 commit into from

Conversation

pohmelie
Copy link
Contributor

@pohmelie pohmelie commented Apr 2, 2016

@dhylands was the original author of this patch, but @pohmelie made
changes to implement toggle.
http://forum.micropython.org/viewtopic.php?f=2&t=1718&p=9829#p9829
dhylands@b16d5d8

@dhylands was the original author of this patch, but @pohmelie made
changes to implement toggle.
@pfalcon
Copy link
Contributor

pfalcon commented Apr 2, 2016

There shouldn't be a reason why FatFs doesn't work with djgpp, so I'd suggest better working in the direction of supporting it.

@pohmelie
Copy link
Contributor Author

pohmelie commented Apr 2, 2016

@pfalcon

../py/../extmod/vfs_fat_file.c:143:32: error: 'ENOTSUP' undeclared (first use in this function)
                     *errcode = ENOTSUP;
                                ^
../py/../extmod/vfs_fat_file.c:143:32: note: each undeclared identifier is reported only once for each function it appears in

djgpp have no ENOTSUP in errno.h http://www.delorie.com/djgpp/doc/libc/libc_293.html

@pfalcon
Copy link
Contributor

pfalcon commented Apr 2, 2016

You can easily define it as a workaround, though we with @dpgeorge decided that there should be mperrno.h with consistent error list and numbering.

@dhylands
Copy link
Contributor

dhylands commented Apr 2, 2016

Having consistent numbering will only work if you're running bare metal. If you're running on an OS (i.e. linux) then you still have to deal with the fact that the values change depeding on the underlying architectures. For example ETIMEDOUT has a different values on say mips-linux versus x86-linux. And the values also change across platforms (windows, mac, linux, unix).
http://www.ioplex.com/~miallen/errcmp.html

@pfalcon
Copy link
Contributor

pfalcon commented Apr 2, 2016

Right, that's why we'll use it only for bare-metal and will base numbering on linux-x86 as the most common. Here, for djgpp, indeed just defining missing symbols (to the values of linux-x86 whenever possible) is the only choice.

@dhylands
Copy link
Contributor

dhylands commented Apr 2, 2016

So how will you deal with the fact that say ETIMEDOUT is different between
linux-mips and linux-x86?

Or are you just saying that bare-metal will use linux-x86 and all of the OS
based ones will use the errno definitions for their OS?

On Sat, Apr 2, 2016 at 10:38 AM, Paul Sokolovsky notifications@github.com
wrote:

Right, that's why we'll use it only for bare-metal and will base numbering
on linux-x86 as the most common. Here, for djgpp, indeed just defining
missing symbols (to the values of linux-x86 whenever possible) is the only
choice.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1956 (comment)

Dave Hylands
Shuswap, BC, Canada
http://www.davehylands.com

@pfalcon
Copy link
Contributor

pfalcon commented Apr 2, 2016

Or are you just saying that bare-metal will use linux-x86 and all of the OS
based ones will use the errno definitions for their OS?

Yes.

@pohmelie
Copy link
Contributor Author

pohmelie commented Apr 2, 2016

Ok, so continue in #1959

@pohmelie pohmelie closed this Apr 2, 2016
tannewt added a commit to tannewt/circuitpython that referenced this pull request Jul 19, 2019
This also improves Palette so it stores the original RGB888 colors.

Lastly, it adds I2CDisplay as a display bus to talk over I2C. Particularly
useful for the SSD1306.

Fixes micropython#1828. Fixes micropython#1956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants