unix/freedos: djgpp errno.h have no ENOTSUP, so define it as "next number" #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,3 +36,6 @@ | |||
|
|
|||
| // djgpp dirent struct does not have d_ino field | |||
| #undef _DIRENT_HAVE_D_INO | |||
|
|
|||
| // djgpp errno.h have no ENOTSUP | |||
There was a problem hiding this comment.
Usual idiom to do such things is to write such defined in #ifndef ENOTSUP. (What if next version of djgpp will define it?)
There was a problem hiding this comment.
@pfalcon
So, I should include errno.h in mpconfigport_freedos.h?
There was a problem hiding this comment.
Hmm, yes, I'd rather say yes, than no.
There was a problem hiding this comment.
@pfalcon, ok, updated.
pohmelie
force-pushed
the
fix-ENOTSUP-for-FreeDOS
branch
from
e0a67a8
to
1620bf1
Compare
|
I also overlooked "next value". Not too robust. Along the lines of discussion above, I changed that to Linux value (88). Merged, thanks! |
tannewt
added a commit
to tannewt/circuitpython
that referenced
this pull request
Jun 22, 2019
Documentation fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1956 solution(?)
This compiles just fine with djgpp.
42, cause 41 is the last one.