Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UART stop bit constants for ESP8266. #3276

Closed
wants to merge 1 commit into from
Closed

Fix UART stop bit constants for ESP8266. #3276

wants to merge 1 commit into from

Conversation

elfmimi
Copy link
Contributor

@elfmimi elfmimi commented Aug 16, 2017

No description provided.

@dpgeorge
Copy link
Member

Thanks for the contribution. Can you please point to / describe where you found these constants? And, did you check that it works as expected?

@elfmimi
Copy link
Contributor Author

elfmimi commented Aug 16, 2017

I found it in "ESP8266 Technical Reference" available here
direct link is https://espressif.com/sites/default/files/documentation/esp8266-technical_reference_en.pdf

11.3.4. Stop Bit
Configure the length of stop bits through setting these two bit
1 : 1 bit
2 : 1.5 bit
3 : 2 bit

I checked that stop=2 setting works as expected (with an Oscilloscope).
There is no way to utilize 1.5bit setting. Hence I have not checked.

@dpgeorge
Copy link
Member

Thanks, merged in ab2c64c

@dpgeorge dpgeorge closed this Aug 21, 2017
tannewt pushed a commit to tannewt/circuitpython that referenced this pull request Aug 14, 2020
@dhalbert
Merge pull request micropython#3276 from xiongyihui/main
9846932 
support to change ble mac address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elfmimi @dpgeorge