New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs isr_rules, micropython: add note that creating a ref to a bound method causes allocation. #3431

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@peterhinch
Contributor

peterhinch commented Nov 12, 2017

As discussed in #3428.

@pfalcon

This comment has been minimized.

Show comment
Hide comment
@pfalcon

pfalcon Nov 12, 2017

Member

This has stray commits, please rebase.

Member

pfalcon commented Nov 12, 2017

This has stray commits, please rebase.

Show outdated Hide outdated docs/library/micropython.rst Outdated
@peterhinch

This comment has been minimized.

Show comment
Hide comment
@peterhinch

peterhinch Nov 12, 2017

Contributor

Has this fixed it? Git continues to baffle me, I'm afraid :(

Contributor

peterhinch commented Nov 12, 2017

Has this fixed it? Git continues to baffle me, I'm afraid :(

@pfalcon

This comment has been minimized.

Show comment
Hide comment
@pfalcon

pfalcon Nov 12, 2017

Member

Nope, as you can see, there're still 2 commits.

In your "doc-ref-bound-method" branch, you need to do "git rebase -i master", then follow the on-screen instructions. (You need to remove a commit not related to this patch.)

Member

pfalcon commented Nov 12, 2017

Nope, as you can see, there're still 2 commits.

In your "doc-ref-bound-method" branch, you need to do "git rebase -i master", then follow the on-screen instructions. (You need to remove a commit not related to this patch.)

@peterhinch

This comment has been minimized.

Show comment
Hide comment
@peterhinch

peterhinch Nov 12, 2017

Contributor

I had to do a force push but hopefully this has worked.

Contributor

peterhinch commented Nov 12, 2017

I had to do a force push but hopefully this has worked.

Show outdated Hide outdated docs/reference/isr_rules.rst Outdated
Show outdated Hide outdated docs/library/micropython.rst Outdated
@peterhinch

This comment has been minimized.

Show comment
Hide comment
@peterhinch

peterhinch Nov 22, 2017

Contributor

Is this OK now?

Contributor

peterhinch commented Nov 22, 2017

Is this OK now?

@dpgeorge

This comment has been minimized.

Show comment
Hide comment
@dpgeorge

dpgeorge Nov 23, 2017

Contributor

Thanks! Merged in ec1e9a1

Contributor

dpgeorge commented Nov 23, 2017

Thanks! Merged in ec1e9a1

@dpgeorge dpgeorge closed this Nov 23, 2017

@peterhinch peterhinch deleted the peterhinch:doc-ref-bound-method branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment