Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for AES GCM mode #6389
base: master
Are you sure you want to change the base?
Support for AES GCM mode #6389
Changes from 1 commit
63c9377
3a2b83c
fce181e
ae6e427
f9cd7c0
3b4782f
1bbd3bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
mp_obj_new_bytes
here.And anyway - it makes no sense you have to do the allocation twice. Before you run encrypt / decrypt - create the final output buffer object, instead of allocating the output buffer twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the problem with doing that is that since strings and bytes are immutable the creation functions compute the hash when the object is created. If I create the object before encrypt/decrypt operation then the empty buffer gets hashed (and then I write over something that is supposed to be immutable). I could find no sign of a function that let me take an existing buffer and hand over ownership to a bytes object, hence doing it this way. If you have a suggestion for a better way to do this which ends up with the correct object hash then Iid be delighted to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
mp_obj_new_str_from_vstr
can be used for that. It will try to reuse the buffer from thevstr
object. But you have to make sure thevstr
is properly allocated with exact size (oflen+1
, + 1 is because allstr
/bytes
in MicroPython are null-terminated)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I've switched over to using that.