extmod/uasyncio: Fix cancellation handling of wait_for. #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 1, 2020
dpgeorge
force-pushed
the
extmod-uasyncio-fix-wait-for
branch
2 times, most recently
from
5825778
to
e274243
Compare
|
Works in my tests too and does look better than my attempts. |
Thanks for testing. I matched some of the additional tests here to yours, which helped iron out bugs. |
This commit switches the roles of the helper task from a cancellation task to a runner task, to get the correct semantics for cancellation of wait_for. Some uasyncio tests are now disabled for the native emitter due to issues with native code generation of generators and yield-from. Fixes micropython#5797. Signed-off-by: Damien George <damien@micropython.org>
dpgeorge
force-pushed
the
extmod-uasyncio-fix-wait-for
branch
from
e274243
to
b505971
Compare
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Aug 5, 2022
Add ability to reserve psram
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #5797 to make
uasyncio.wait_for()handle cancellation correctly.This is an alternative to #5918 and #5931. The advantage of the approach here is that it still only uses one extra task (one extra call to
create_task()) to implement the wait-for. It basically switches the roles of this helper task from a cancellation task to a runner task.Note that the
asyncio.get_event_loop().set_exception_handler(lambda loop, context: None)line needed in the test can be removed if/when #6664 is merged.