Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open citations: Papers and Citeulike don't work #62

Closed
Melissa37 opened this issue May 17, 2019 · 4 comments
Closed

Open citations: Papers and Citeulike don't work #62

Melissa37 opened this issue May 17, 2019 · 4 comments
Assignees
@giorgiosironi @BlueReZZ

Comments

@Melissa37
Copy link
Collaborator

Nothing happens if you click on Papers
Screenshot 2019-05-17 at 15 28 21

This is what happens for Citeulike:
Screenshot 2019-05-17 at 15 29 29
@BlueReZZ
Copy link
Contributor

BlueReZZ commented May 17, 2019 •
edited
Loading

The Libero MVP which IJM will use is only planned to have a single download button for the PDF so these should probably be removed/hidden otherwise users may expect the same on launch.

@Melissa37
Copy link
Collaborator Author

Thanks @BlueReZZ - who can do this? Who should this be assigned to?

@BlueReZZ
Copy link
Contributor

BlueReZZ commented May 17, 2019 •
edited
Loading

I can probably do it with some assistance from @giorgiosironi as it seems to be a case of removing some lines here:

https://github.com/microsimulation/demo/blob/6c060a9aa600ea420c86f39bc786483da4b7fb36/journal/src/ViewModel/Converter/ArticleDownloadLinksListConverter.php#L55

@BlueReZZ
Copy link
Contributor

This has been done under PR microsimulation/demo#11 and merged. Just waiting for @giorgiosironi to deploy it

@BlueReZZ BlueReZZ mentioned this issue May 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giorgiosironi giorgiosironi

@BlueReZZ BlueReZZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@giorgiosironi @BlueReZZ @Melissa37