-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting panel blank when added to modern site using GitHub -- YannickRe/spfx-msgraph-peoplesearch on same page #1964
Comments
Seems like an edge case and we cannot control what other web parts do. @YannickRe might have an idea why it happens? And errors in the console would be useful. |
No clue, but it’s probably due to my bad coding 🤣. |
@YannickRe you broke the Modern Search 🤣! More serioulsy, maybe https://github.com/YannickRe/spfx-msgraph-peoplesearch/blob/6463067482f96a8b597769dfb51a6e4f168f796e/src/webparts/peoplesearch/PeopleSearchWebPart.ts#L49 could cause an issue iwth components loaded by the Search Results Web Part. |
I "borrowed" some code/approach from Modern Search, so that might explain it 😄 |
I'll close this issue as the solutions are not compatible "by design". If someone/Yannik wants to change code, that's ok 🙂 |
I will fix it, the whole point is that they can work together :) |
@Id10tSupport I released a new version of my webpart => https://github.com/YannickRe/spfx-msgraph-peoplesearch/releases/tag/v2.6.0 I couldn't reproduce the issue so I just changed what Frank told me to 😉. If it doesn't fix your issue, please create a issue in my repository! |
I'll test it out and let you know how it goes. Thanks!! |
It's because of #407, as I was using an updated version of react-ace on the page but that creates conflicts. For now, I downgraded to 5.8.0. |
Version used
v4.5.4
Describe the bug
Using a modern Communication site. Can add the modern search webpart just fine and can configure without issue. After adding GitHub -- YannickRe/spfx-msgraph-peoplesearch to same page, can no longer edit config for the modern search webpart. If the peoplesearch webpart is on the page already when adding modern search webpart, no ability to edit settings at all. Even if remove PeopleSearch webpart from page, still cannot edit setting for modern search.
Version of PeopleSearch is most current - v2.5.0
To Reproduce
Steps to reproduce the behavior:
-- if you save and publish the page then edit again, the side panel for the Modern Search webpart will be blank
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: