Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting panel blank when added to modern site using GitHub -- YannickRe/spfx-msgraph-peoplesearch on same page #1964

Closed
Id10tSupport opened this issue Mar 25, 2022 · 9 comments
Labels
Needs: Triage Needs investigation and repro v4 version 4

Comments

@Id10tSupport
Copy link

Version used
v4.5.4

Describe the bug
Using a modern Communication site. Can add the modern search webpart just fine and can configure without issue. After adding GitHub -- YannickRe/spfx-msgraph-peoplesearch to same page, can no longer edit config for the modern search webpart. If the peoplesearch webpart is on the page already when adding modern search webpart, no ability to edit settings at all. Even if remove PeopleSearch webpart from page, still cannot edit setting for modern search.

Version of PeopleSearch is most current - v2.5.0

To Reproduce
Steps to reproduce the behavior:

  1. Add Modern Search webpart to page
  2. Edit configuration for webpart
  3. Add People Search webpart to page
  4. Edit configuration for People Search webpart
  5. Attempt to edit configuration for Modern Search webpart -- side panel remains that of the People Search webpart
    -- if you save and publish the page then edit again, the side panel for the Modern Search webpart will be blank

Desktop (please complete the following information):

  • Windows 10/11
  • Chrome
  • Edge
@wobba wobba added Needs: Triage Needs investigation and repro v4 version 4 labels Mar 26, 2022
@wobba
Copy link
Collaborator

wobba commented Mar 26, 2022

Seems like an edge case and we cannot control what other web parts do. @YannickRe might have an idea why it happens?

And errors in the console would be useful.

@YannickRe
Copy link
Contributor

No clue, but it’s probably due to my bad coding 🤣.
I’ll take a look!

@FranckyC
Copy link
Collaborator

@YannickRe you broke the Modern Search 🤣! More serioulsy, maybe https://github.com/YannickRe/spfx-msgraph-peoplesearch/blob/6463067482f96a8b597769dfb51a6e4f168f796e/src/webparts/peoplesearch/PeopleSearchWebPart.ts#L49 could cause an issue iwth components loaded by the Search Results Web Part.

@YannickRe
Copy link
Contributor

I "borrowed" some code/approach from Modern Search, so that might explain it 😄

@wobba
Copy link
Collaborator

wobba commented Mar 30, 2022

I'll close this issue as the solutions are not compatible "by design". If someone/Yannik wants to change code, that's ok 🙂

@wobba wobba closed this as completed Mar 30, 2022
@YannickRe
Copy link
Contributor

I will fix it, the whole point is that they can work together :)

@YannickRe
Copy link
Contributor

@Id10tSupport I released a new version of my webpart => https://github.com/YannickRe/spfx-msgraph-peoplesearch/releases/tag/v2.6.0

I couldn't reproduce the issue so I just changed what Frank told me to 😉. If it doesn't fix your issue, please create a issue in my repository!

@Id10tSupport
Copy link
Author

I'll test it out and let you know how it goes. Thanks!!

@YannickRe
Copy link
Contributor

It's because of #407, as I was using an updated version of react-ace on the page but that creates conflicts. For now, I downgraded to 5.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage Needs investigation and repro v4 version 4
Projects
None yet
Development

No branches or pull requests

4 participants