Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LgEditor shows wrong content and is not editable #3783

Closed
8 tasks
yeze322 opened this issue Aug 5, 2020 · 2 comments · Fixed by #3784
Closed
8 tasks

LgEditor shows wrong content and is not editable #3783

yeze322 opened this issue Aug 5, 2020 · 2 comments · Fixed by #3784
Labels
Type: Bug Something isn't working

Comments

@yeze322
Copy link
Contributor

yeze322 commented Aug 5, 2020 •
edited
Loading

Describe the bug

(reported by @lei9444 )

lg-issue

Version

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots

Additional context
@yeze322 yeze322 added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Aug 5, 2020
@yeze322
Copy link
Contributor Author

yeze322 commented Aug 5, 2020

Root cause: PropertyEditor is editing wrong data, it receives the whole dialog instead of a selected Action

@yeze322 yeze322 mentioned this issue Aug 5, 2020
Merged
@yeze322
Copy link
Contributor Author

yeze322 commented Aug 5, 2020

addressed in #3784

@yeze322 yeze322 changed the title Cannot edit an Action in PropertyEditor LgEditor shows wrong content Aug 5, 2020
@yeze322 yeze322 added P0 Must Fix. Release-blocker and removed Needs-triage A new issue that require triage labels Aug 5, 2020
@yeze322 yeze322 changed the title LgEditor shows wrong content LgEditor shows wrong content and is not editable Aug 5, 2020
@yeze322 yeze322 added P0 Must Fix. Release-blocker and removed P0 Must Fix. Release-blocker labels Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use different shellData in Form and Flow's ExtensionContext yeze322/BotFramework-Composer
1 participant
@yeze322