Improved Tab Accessibility and Refactored Markup #1131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulator into toanzian/tabs-refactor
Pull Request Test Coverage Report for Build 1468
💛 - Coveralls |
justinwilaby
previously approved these changes
Nov 28, 2018
packages/app/client/src/ui/shell/mdi/documents/documentsContainer.ts
Outdated
Show resolved
Hide resolved
packages/app/client/src/ui/shell/mdi/tabbedDocument/tabbedDocument.tsx
Outdated
Show resolved
Hide resolved
justinwilaby
approved these changes
Nov 29, 2018
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1098
=======
Tabs will now read out two separate times using a screen reader (NVDA):
Also significantly refactored the markup for
<MDI/><MultiTabs/>&<TabbedDocument/>Removed
/ui/shell/multiTabsand moved all contents to/ui/shell/mdi/...