Make Accepted proposal details visible to constitution's apply()

[eddyashton]

(Includes #6112, #6113, #6115, so merge those first)

Goal of the change is as in the title, resolving #6108. Includes an overwrought e2e test. Only changes the new governance API, with associated cleanup that I think has no other semantic (API) impact.

[ccf-bot]

proposal_clarity@83706 aka 20240415.22 vs main ewma over 20 builds from 83376 to 83718

Click to see table

main

build_id	build_number	pi_basic_mt_sgx_cft^	pi_basic_mt_sgx_cft_mem	Commit latency factor	tpcc_sgx_cft^	tpcc_sgx_cft_mem	pi_basic_mt_virtual_cft^	tpcc_virtual_cft^	ls_virtual_cft^	pi_ls_virtual_cft^	ls_sgx_cft^	ls_sgx_cft_mem	pi_basic_virtual_cft^	pi_ls_sgx_cft^	pi_ls_sgx_cft_mem	pi_basic_sgx_cft^	pi_basic_sgx_cft_mem	pi_basic_js_virtual_cft^	ls_jwt_virtual_cft^	pi_ls_jwt_virtual_cft^	ls_js_virtual_cft^	ls_full_js_virtual_cft^	pi_basic_js_sgx_cft^	pi_basic_js_sgx_cft_mem	ls_js_jwt_virtual_cft^	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	pi_ls_jwt_sgx_cft^	pi_ls_jwt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	hist_sgx_cft^	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	KV ser (/s)^	KV deser (/s)^	KV snap ser (/s)^	KV snap deser (/s)^	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^	tlc_sim_traces	tlc_sim_levelmean
83376	20240402.3	27361.3	2.30851e+07	0.799042	5555.59	8.59996e+07	83080.8	17267.7	52955.6	56862.8	13917	1.88908e+07	59519.2	13907.4	1.05021e+07	15383.4	1.46964e+07	4425.2	20973.4	21697.2	17487.8	17373.7	1360.3	1.25993e+07	11609.4	6825.59	1.88908e+07	6927.1	6.30784e+06	5807.65	1.67936e+07	5487.31	1.67936e+07	42110.8	4008.13	1.67936e+07	1.01843e+06	1.15929e+06	7701.94	1408.13	832051	1.18464e+06	8.12041e+06	3.08708e+07	29810	383
83387	20240402.7	27679.7	2.51822e+07	0.818038	5579.52	8.59996e+07	88136.4	17383.2	52921.2	56391.1	13822	1.88908e+07	61114.2	13861.3	1.05021e+07	15353.6	1.46964e+07	4398.2	20676	20801.7	17423.3	17097.1	1366.2	1.25993e+07	11687.5	6873.64	1.88908e+07	6885.7	6.30784e+06	5799.29	1.67936e+07	5470.11	1.67936e+07	46105.2	3964.49	1.67936e+07	1.04178e+06	1.16239e+06	7986.02	1403.94	828227	1.17352e+06	8.15313e+06	3.17092e+07	29554	372
83394	20240403.3	27512.2	2.51822e+07	0.795653	5570.57	8.59996e+07	69002.8	17334.1	53089.2	56972.9	13917.8	1.88908e+07	61037.5	13938.1	1.05021e+07	15484.8	1.46964e+07	4413.7	20606.5	20959.1	17670.3	17377.7	1369.5	1.25993e+07	11765.2	7186.56	1.67936e+07	6957.1	6.30784e+06	5802.37	1.67936e+07	5479.51	1.67936e+07	44785.5	3995.27	1.67936e+07	1.03455e+06	1.17966e+06	7801.67	1406.73	833321	1.18091e+06	8.14314e+06	3.07166e+07	30720	376
83408	20240404.3	27743	2.30851e+07	0.836361	5617.23	8.59996e+07	96525.6	17318.8	52945.7	56267	13941.1	1.88908e+07	62433.5	14037.1	1.05021e+07	15562.4	1.46964e+07	4456.1	21107	21717.9	17490.4	17251.1	1363.3	1.25993e+07	11722.5	6903.33	1.88908e+07	6887.4	6.30784e+06	5799.01	1.67936e+07	5463.66	1.67936e+07	39727.3	3987.88	1.67936e+07	1.02987e+06	1.13404e+06	7745.13	1402.62	831256	1.17788e+06	8.13557e+06	3.07554e+07	30391	379
83419	20240404.5	27958.6	2.30851e+07	0.821804	5577.86	8.59996e+07	69081.1	17256.1	52901.3	56589.6	13973.3	1.67936e+07	61906	13977.4	1.05021e+07	15377.4	1.46964e+07	4403.3	20590.2	21153.3	17442.8	17106.5	1365.9	1.25993e+07	11674.1	6825.56	1.88908e+07	6917.7	6.30784e+06	5803.51	1.67936e+07	5458.29	1.67936e+07	45979	3801.64	1.67936e+07	1.00847e+06	1.12562e+06	7474.96	1398.42	845103	1.17785e+06	8.13509e+06	3.11663e+07	32428	382
83433	20240405.2	27805.9	2.30851e+07	0.795203	5610.51	8.59996e+07	73717.7	17432.5	53095.5	55527.2	13933.8	1.67936e+07	61761.9	14008.4	1.05021e+07	15466.9	1.25993e+07	4429	20818	21148.8	17215.2	17096.2	1360.5	1.25993e+07	11509	6820.03	1.88908e+07	6932.1	6.30784e+06	5755.14	1.67936e+07	5461.46	1.67936e+07	44641.6	3987.78	1.67936e+07	1.0175e+06	1.18779e+06	8272.95	1408.52	837389	1.1752e+06	8.15196e+06	3.06927e+07	30697	373
83446	20240408.2	27601.3	2.30851e+07	0.80954	5516.27	8.59996e+07	91917.1	17447.2	53117.1	55958.8	13896.2	1.88908e+07	61153.3	13970.4	1.05021e+07	15383.1	1.46964e+07	4432.1	20761.9	20873.8	17457.9	17374.6	1363	1.25993e+07	11529.9	6825.46	1.88908e+07	6988.6	6.30784e+06	5759.72	1.67936e+07	5425.1	1.67936e+07	47154.6	3992.3	1.67936e+07	1.02533e+06	1.10779e+06	7833.59	1393.37	813419	1.18481e+06	8.14959e+06	3.15227e+07	31171	383
83465	20240409.3	27515.3	2.30851e+07	0.819344	5595.61	8.59996e+07	93716.1	17275.2	53026.3	56413.7	13937.9	1.67936e+07	62184.1	13959.8	1.05021e+07	15443.9	1.46964e+07	4436.4	20560.2	21632.4	17479.3	17314.9	1360.5	1.25993e+07	11682.1	6888.84	1.88908e+07	7084.5	6.30784e+06	5785.52	1.67936e+07	5456.19	1.67936e+07	45530.7	3964.71	1.67936e+07	1.05053e+06	1.13559e+06	7700.05	1398.41	839459	1.18433e+06	8.15345e+06	3.08211e+07	31097	380
83491	20240409.11	27923.2	2.51822e+07	0.788667	5577.9	8.59996e+07	95032.1	17216.4	52730.3	57049	13915.5	1.88908e+07	60114	13948.1	1.05021e+07	15257.7	1.46964e+07	4376.3	20863.8	22315	17644.1	17141.5	1350.5	1.25993e+07	11680.7	6833.2	1.88908e+07	6936.2	6.30784e+06	5782.62	1.67936e+07	5459.02	1.67936e+07	43435.3	3807.6	1.67936e+07	1.01225e+06	1.15969e+06	7776.73	1406.33	833597	1.17995e+06	8.15121e+06	3.15465e+07	29923	371
83516	20240410.3	27661	2.51822e+07	0.820327	5559.4	8.59996e+07	77993.3	17408.1	52988.5	55669.4	13897	1.88908e+07	58564.1	13983.7	1.05021e+07	15330.8	1.46964e+07	4341.5	20881.9	22172	17604.5	17131.6	1365.5	1.05021e+07	11516.6	7191.21	1.67936e+07	6872.9	6.30784e+06	5784.58	1.67936e+07	5461.12	1.67936e+07	46259.3	3974.35	1.67936e+07	1.04712e+06	1.11433e+06	7652.8	1399.18	829881	1.18481e+06	8.13531e+06	3.0748e+07	31688	378
83524	20240410.5	27560.8	2.51822e+07	0.802161	5566.3	8.59996e+07	77062.9	17232.4	52988.3	57020.7	13947.6	1.67936e+07	60754	14044.3	1.05021e+07	15463.8	1.46964e+07	4424.8	17578.5	21873.2	17603.5	17103.2	1370.2	1.25993e+07	11561.1	7229.68	1.67936e+07	6998.4	6.30784e+06	5759.07	1.67936e+07	5469.21	1.67936e+07	44620.9	3982.97	1.67936e+07	1.03918e+06	1.17661e+06	8224.64	1408.31	839904	1.17574e+06	8.13738e+06	3.08834e+07	31607	384
83548	20240411.2	27689.7	2.51822e+07	0.824138	5607.15	8.59996e+07	66739	17210.8	52940.3	56584.8	13939.6	1.67936e+07	61285.2	14071.7	1.05021e+07	15436.3	1.25993e+07	4401.1	20862.1	21969.8	17551.3	17283	1366.1	1.25993e+07	11494.4	6841.5	1.88908e+07	6878.9	6.30784e+06	5790.47	1.67936e+07	5457.03	1.67936e+07	43389.8	3958.92	1.67936e+07	1.04297e+06	1.1722e+06	7930.42	1400.58	836833	1.17803e+06	8.15017e+06	3.07651e+07	29736	377
83561	20240411.8	27419.8	2.30851e+07	0.812126	5513.17	8.59996e+07	84111.9	17310.1	53142.9	55831.9	13991.3	1.88908e+07	60447.1	14012.3	1.05021e+07	15256	1.46964e+07	4426.8	20937.9	22065.3	17587.6	17268.9	1361.1	1.25993e+07	11657	7208.84	1.67936e+07	7010.4	6.30784e+06	5757.92	1.67936e+07	5485.1	1.67936e+07	42451.7	3967.59	1.67936e+07	1.01874e+06	1.14626e+06	7628.61	1397.55	834446	1.17887e+06	8.15429e+06	3.11701e+07	31146	370
83575	20240411.14	27574.4	2.30851e+07	0.810011	5541.86	8.59996e+07	70051.8	16816.1	53136.1	55252.9	13851.7	1.88908e+07	60586.4	13944	1.05021e+07	15145.1	1.46964e+07	4364.3	20640.6	21555	17274.5	17973.1	1357.7	1.25993e+07	11534.2	6808.77	1.67936e+07	6877.6	6.30784e+06	5738.61	1.67936e+07	5427.42	1.67936e+07	39578.1	3805.11	1.67936e+07	1.01461e+06	1.14456e+06	7640.76	1403.34	838300	1.17792e+06	8.13444e+06	3.06532e+07	30477	384
83594	20240412.2	27746.4	2.51822e+07	0.778222	5633.59	8.59996e+07	70582.5	17471.7	53108.6	56340.9	13909.6	1.88908e+07	61266.1	14038.6	1.05021e+07	15425.7	1.25993e+07	4433.7	20692.3	22185.7	17141.4	17139.9	1362.8	1.25993e+07	11542	7217.68	1.67936e+07	6868.1	6.30784e+06	5790.23	1.67936e+07	5452.72	1.67936e+07	38586	3989.98	1.67936e+07	997904	1.15194e+06	7926.93	1404.25	836820	1.17884e+06	8.15524e+06	3.065e+07	30690	374
83618	20240412.12	27694.6	2.51822e+07	0.790379	5607.27	8.59996e+07	88740.9	17440.9	53138.7	55688.6	13919	1.88908e+07	61148.6	14023.5	1.05021e+07	15491.4	1.46964e+07	4398.3	20639.7	21416.9	17071.7	17528.5	1372.1	1.05021e+07	11430.4	6809	1.67936e+07	7039.8	6.30784e+06	5770.46	1.67936e+07	5453.33	1.67936e+07	43299.8	3977.28	1.67936e+07	1.03638e+06	1.19332e+06	7840.6	1406.97	837854	1.18407e+06	8.15231e+06	3.09581e+07	32407	368
83641	20240415.3	27523.6	2.30851e+07	0.776887	5627.33	8.59996e+07	93199.7	17323.7	53050.4	56883.5	13964.3	1.67936e+07	62579.3	14023.2	1.05021e+07	15473.5	1.46964e+07	4377.5	21214.8	21756.6	17224.3	17612.2	1360.1	1.25993e+07	11429.6	6848.25	1.67936e+07	6934.3	6.30784e+06	5785.3	1.67936e+07	5451.5	1.67936e+07	45669.7	3795.38	1.67936e+07	997208	1.14116e+06	8362.53	1404.68	835227	1.18569e+06	8.15387e+06	3.07623e+07	29478	385
83644	20240415.4	27870.4	2.51822e+07	0.810067	5600.24	8.59996e+07	95534.6	17286.2	52799.1	55584.3	13937.9	1.88908e+07	61537.7	14059.6	1.05021e+07	15481.2	1.25993e+07	4390.7	20660.8	22135.6	17636.8	17686.6	1365.2	1.25993e+07	11565.7	7192.76	1.67936e+07	6866.4	6.30784e+06	5760.09	1.67936e+07	5414.46	1.67936e+07	43965.9	3938.89	1.67936e+07	1.03896e+06	1.12994e+06	7868.03	1401.74	839603	1.18e+06	8.17519e+06	3.08178e+07	31602	377
83698	20240415.20	27490.4	2.30851e+07	0.777621	5593.97	8.59996e+07	67929.5	17227.9	52976.3	56041.9	13922.5	1.88908e+07	62006	14040.3	1.05021e+07	15501.7	1.25993e+07	4387.1	20981.1	21832.2	17235.5	17447.4	1369.3	1.05021e+07	11400.1	6800.92	1.67936e+07	7031.2	6.30784e+06	5733.35	1.67936e+07	5435.7	1.67936e+07	43589.4	3964.27	1.67936e+07	1.01297e+06	1.18287e+06	8254.33	1401.83	830349	1.1788e+06	8.11015e+06	3.07512e+07	31129	388
83718	20240416.2	27554.2	2.51822e+07	0.827002	5620.84	8.59996e+07	91285.3	17525.3	52893.5	55848.1	13913.3	1.67936e+07	62309.2	14016.3	1.05021e+07	15353.1	1.25993e+07	4394.9	20814.8	21663.3	17322.9	17692.4	1365.3	1.25993e+07	11572.9	6785.78	1.67936e+07	6879	6.30784e+06	5773.22	1.67936e+07	5445.46	1.67936e+07	45395.9	3961.8	1.67936e+07	1.02365e+06	1.10327e+06	7685.14	1405.45	836684	1.18258e+06	8.15034e+06	3.18363e+07	31533	380

proposal_clarity

build_id	build_number	pi_basic_mt_sgx_cft^	pi_basic_mt_sgx_cft_mem	Commit latency factor	tpcc_virtual_cft^	ls_virtual_cft^	pi_ls_virtual_cft^	pi_basic_virtual_cft^	pi_basic_js_virtual_cft^	tpcc_sgx_cft^	tpcc_sgx_cft_mem	ls_jwt_virtual_cft^	pi_ls_jwt_virtual_cft^	ls_js_virtual_cft^	ls_full_js_virtual_cft^	ls_js_jwt_virtual_cft^	ls_sgx_cft^	ls_sgx_cft_mem	pi_ls_sgx_cft^	pi_ls_sgx_cft_mem	pi_basic_sgx_cft^	pi_basic_sgx_cft_mem	pi_basic_mt_virtual_cft^	hist_sgx_cft^	pi_basic_js_sgx_cft^	pi_basic_js_sgx_cft_mem	ls_jwt_sgx_cft^	ls_jwt_sgx_cft_mem	pi_ls_jwt_sgx_cft^	pi_ls_jwt_sgx_cft_mem	ls_js_sgx_cft^	ls_js_sgx_cft_mem	ls_full_js_sgx_cft^	ls_full_js_sgx_cft_mem	ls_js_jwt_sgx_cft^	ls_js_jwt_sgx_cft_mem	KV ser (/s)^	KV deser (/s)^	KV snap ser (/s)^	KV snap deser (/s)^	RB put (/s)^	CHAMP put (/s)^	RB get (/s)^	CHAMP get (/s)^	tlc_sim_traces	tlc_sim_levelmean
83531	20240410.7	27973.9	2.30851e+07	0.789497	17364	52903.4	54354.9	59725.6	4364.5	5644.83	8.39025e+07	17459.2	21250.8	17088.4	17088.7	11533.2	13936.9	1.67936e+07	14085.3	1.05021e+07	15492.6	1.25993e+07	68600.8	39845.8	1363.5	1.25993e+07	7219.77	1.67936e+07	6928.4	6.30784e+06	5794.92	1.67936e+07	5473.49	1.67936e+07	3998.06	1.67936e+07	1.03724e+06	1.13417e+06	8077.22	1407.64	827754	1.17988e+06	8.17356e+06	3.08722e+07	32094	379
83600	20240412.4	27531.6	2.30851e+07	0.810632	17247	53410.9	56792.7	61836	4407.2	5581.46	8.59996e+07	20836.9	21213	17346.6	17131.4	11798.9	13831.7	1.88908e+07	13898.6	1.05021e+07	15300.2	1.46964e+07	85726.7	46704.2	1368.5	1.25993e+07	6805.86	1.67936e+07	6870.3	6.30784e+06	5780.16	1.67936e+07	5468.95	1.67936e+07	3984.88	1.67936e+07	1.03381e+06	1.15367e+06	7746.36	1397.16	833981	1.18031e+06	8.14049e+06	3.07961e+07	30741	381
83661	20240415.9	27252.1	2.30851e+07	0.816765	17209.9	50695.6	54603.9	60474.9	4372.6	5526.04	8.59996e+07	20590.4	21470.3	17109.8	17194.4	11603.1	13860	1.67936e+07	13907.9	1.05021e+07	15287.1	1.46964e+07	89266.1	43551.2	1350.3	1.25993e+07	7170.07	1.88908e+07	6809.9	6.30784e+06	5723.5	1.67936e+07	5443.46	1.67936e+07	3788.97	1.67936e+07	1.02838e+06	1.13649e+06	7955.02	1405.85	833603	1.18703e+06	8.15696e+06	3.09412e+07	30681	383
83706	20240415.22	27493.7	2.30851e+07	0.786807	17218.3	53373.3	56022.7	61232.7	4381.6	5586.28	8.59996e+07	20669.5	21777	17401.8	17455.8	11623.2	13843.3	1.67936e+07	13967.2	1.05021e+07	15363.2	1.46964e+07	71995.7	46122	1344.9	1.25993e+07	6752.6	1.88908e+07	6872.6	6.30784e+06	5488.92	1.67936e+07	5448.87	1.67936e+07	3958.66	1.67936e+07	1.0469e+06	1.16537e+06	8335.9	1394.9	841768	1.1801e+06	8.1504e+06	3.09585e+07	32688	381

[achamayou]

Two suggestions:

1. The usual daily canary to get the long LTS
2. Adding a pass over ledgers, post-run, checking that len(ballots) = len(v for v final_votes.values() if v), for the final states where we have decided to store them.

[achamayou]

@eddyashton this feels like something that deserves a mention in the CHANGELOG.