Don't log JS exception details by default

[eddyashton]

Restoring intended initial values for these 2 bools, which were accidentally updated to verbose-by-default in a recent refactor.

[achamayou]

@eddyashton that seems like a thing we really ought to have a test for.

[eddyashton]

@eddyashton that seems like a thing we really ought to have a test for.

I 100% agree, but while trying to add that I've decided it deserves a bigger cleanup. The entire way we fetch and report the JS config is messy, with various paths taken to determine defaults when the JSEngine KV value doesn't exist. I think we should squash that entirely - the default constructor of a JSEngine contains the default values, you get the default if there's none in the KV, and then you always have a JSEngine object to work with. I'll do that, but not in this PR.

[achamayou]

@eddyashton I agree with that too, but I think in this case it's just a canary that runs an endpoint that produces an error and checks nothing gets logged unless this is on, it's quite orthogonal, and a good thing to have around as we refactor the JS runtime substantially.

[achamayou]

@eddyashton So we have (almost!) exactly that test:

CCF/tests/js-modules/modules.py

Line 1339 in bdac0c4

def test_js_exception_output(network, args):

But! Because it doesn't run first, and set_js_runtime_options is used in a number of other tests before, a change that affects the default will not be caught.

I will move it up.