Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework package to link against? #67

Closed
hansmbakker opened this issue Jun 3, 2019 · 16 comments
Closed

Framework package to link against? #67

hansmbakker opened this issue Jun 3, 2019 · 16 comments

Comments

@hansmbakker
Copy link

hansmbakker commented Jun 3, 2019

(Coming from .Net background, not sure if this is common for driver development)

Seeing that C++/WinRT is distributed as a NuGet package now, I'm wondering whether DMF could be released as a (NuGet) package as well?

Meaning - a packaged version of a compiled version together with the required headers?

Advantages for developers would be a easier consumption, a cleaner project repository and clear dependency management.

@samtertzakian
Copy link
Member

We will discuss internally and get back to you. Thank you for your suggestion. (Internally, we use Nuget packages for our own private DMF in our build system.)

@hansmbakker
Copy link
Author

Thank you!

@hansmbakker
Copy link
Author

I was wondering whether you’ve had the chance of discussing this, and what the outcome was?

(I can imagine that even if your colleagues approved it could still require effort since currently it is used for internal builds that probably need to stay separated?)

@hansmbakker
Copy link
Author

hansmbakker commented Aug 30, 2019

Hi @samtertzakian,
could you say something about the state of this issue?

@samtertzakian
Copy link
Member

Hi, Hans,

We have not had a chance to address this issue directly. However, it is on our list. We have been using Nuget internally with DMF and other libraries. There will not be any progress on this issue from our end for at least another couple of months due to our schedules. For this reason, this issue remains open.

We have discussed this issue and we plan to work on it. Our solution needs to work seamlessly in our organization which is very large and has many consumers including our build organization.

@hansmbakker
Copy link
Author

Thank you for making this clear!

@samtertzakian
Copy link
Member

Hi, Hans. Internally we are reorganizing how we use DMF from Github. So we addressing the issues you raised in this thread. I am not sure how long it will take or what the final outcome will be. I will keep you up to date here however. We have not forgotten this issues.

@samtertzakian
Copy link
Member

Hi, Hans, we are still working on this task but making progress. Just fyi...

@nefarius
Copy link
Contributor

Not a 100% what you're after but I created a little helper to make DMF inclusion a breeze!

@samtertzakian
Copy link
Member

Hi nefarius,

Do you think we should include your file in the Dmf directory and and update the documentation to include what you wrote?
We could update all the sample drivers to use the .props file.

If you would like to create a PR with that it would be great. Or, I can do it.

I need to try it out myself, but I think what you did is simpler than the legacy manner in which the samples include DMF now.

@nefarius
Copy link
Contributor

Do you think we should include your file in the Dmf directory and and update the documentation to include what you wrote?
We could update all the sample drivers to use the .props file.

Sure, if it makes life easier for everyone!

If you would like to create a PR with that it would be great. Or, I can do it.

I need to try it out myself, but I think what you did is simpler than the legacy manner in which the samples include DMF now.

I'll try to migrate the samples in my fork and when successful will gladly provide a PR. Whoever makes it first 😉

@samtertzakian
Copy link
Member

samtertzakian commented Feb 15, 2022

Let put the Dmf.Props file next to the DmfVersion.h file. Then, lets update the documentation "Special Topics" section with the text you wrote. Does that sound good? I can do it if you like. I just don't want to do it if you started it.

After that PR is in, I will update the samples to use the Dmf.Props file.

@nefarius
Copy link
Contributor

Sounds good! No I haven't started any work on this yet.

@samtertzakian
Copy link
Member

Hi i have not forgotten about this....it is in the pipeline...just had some other critical issues....

@samtertzakian
Copy link
Member

There is a PR pending to resolve this issue: #210

Samples have been updated to illustrate the use of this method. Documentation has also been updated. Thank you, nefarius for the suggestion.

Release v1.1.119 will have this change.

@samtertzakian
Copy link
Member

Master has the update. Next month it will be in Release v1.1.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants