User should be able to provide context class when using async methods #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The reason we did not include Context in the async API is that there seemed to be no good use case for contexts in the async world, since the call stack is available after the await. But yes, I agree it still makes sense to let users provide it because |
|
We could merge this so users can switch seamlessly between blocking and async code, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #239 .
If the Functions class depends on the Context instance, async methods will make it fail with a Null Reference Exception.
As per #238, full adherence to TLP semantics would see callbacks on the Functions class gone, maybe replaced by injected middleware semantics, ASPNET.CORE style.