v3.2.0 release #3872

guolinke · 2021-01-28T02:17:33Z

This is a stable release.
The next release may is 4.0.0, for many breaking changes. And it may take a long time to finish.
So it better to fix the critical bugs in 3.2.0.

Please list the PR need to be merged in this release.

jameslamb · 2021-01-28T04:38:42Z

Please list the PR need to be merged in this release.

Dask

The Dask interface doesn't need to be perfect for 3.2.0 and it's ok for it to have only limited functionality, but there are some Dask items I'd still like to get done before releasing 3.2.0. Since there has never been a release with Dask in it, I want to put in enough thought and work that we have some confidence that breaking changes won't be necessary in the future.

This is the minimal list of issues I'd like to be done before 3.2.0, to feel confident in that release:

tutorial documentation for Dask ([dask] tutorial documentation #3814)
document how to save a Dask model ([docs] [dask] Document how to save a Dask model #3838)
~~BUG: DaskLGBMClassifier very slow and not using CPU ([dask] DaskLGBMClassifier very slow and not using CPU #3797)~~ v3.2.0 release #3872 (comment)
Dask API docs ([RFC] [dask] [docs] Override details in API docs that differ between dask and sklearn interfaces #3871)
~~BUG: DaskLGBMRanker sometimes returns an incomplete booster ([dask] Dask estimators sometimes return an incomplete booster #3918)~~
BUG: DaskRegressor.fit() fails on Dask DataFrame / Series ([dask] DaskRegressor.predict() fails on DataFrame / Series input #3861)
decide how Dask client is provided ([RFC] [dask] decide and document how users should provide a Dask client at training time #3808)
add type hints in Dask docs ([dask] Add type hints in Dask package #3866)

I'm able to spend some time at work working on this, but I still expect that it would take 1-3 weeks for these to get done. It's only me and @StrikerRUS working on the Dask package and reviewing each others' PRs (with occasional contributions from outside contributors). Is that ok, or do you want to get 3.2.0 out sooner?

R package

There are no features or bugs for the R package that I think absolutely need to be done before a 3.2.0 release.

guolinke · 2021-01-28T10:06:02Z

@jameslamb no hurry, we can take the time.
@shiyu1994 I think we can setup a dev branch for 4.0.0, and maybe some PRs could merge to dev branch first. then rebase to master after 3.2.0 release.

StrikerRUS · 2021-01-28T11:57:05Z

StrikerRUS · 2021-01-28T12:03:55Z

shiyu1994 · 2021-01-28T13:17:19Z

@jameslamb no hurry, we can take the time.
@shiyu1994 I think we can setup a dev branch for 4.0.0, and maybe some PRs could merge to dev branch first. then rebase to master after 3.2.0 release.

Ok. Maybe 4.0.0 can include category encoding, symmetric trees, and the on-going efficiency optimizations.

guolinke · 2021-02-06T02:11:45Z

@shiyu1994 it seems this release still need some time. You can create a dev branch, and merge your PRs to that branch first.

jameslamb · 2021-02-07T04:11:07Z

~~I'm sorry, but I just found another serious issue in the Dask package: #3918. It's my next priority, and I think it needs to be fixed before the release.~~

EDITt: False alarm, I think some of what I saw was just a result of using very very small data in tests. #3918 (comment)

StrikerRUS · 2021-02-16T02:20:08Z

@jameslamb May I ask you a question? Why do you think that documentation PRs should block new release? All our docs are available online and can be updated independently from source code that is being uploaded to differente package managers with each release. We don't have any "snapshots" for docs...

jameslamb · 2021-02-16T02:40:47Z

@jameslamb May I ask you a question? Why do you think that documentation PRs should block new release?

This period right now, before the release, is the only chance we'll ever have to freely break the API of lightgbm.dask with minimal user impact. Once that module is part of a formal release, we have to be much more hesitant about breaking changes.

The particular issues I've linked (#3814, #3838) are about high-level documentation of the interface. We might find some inconsistencies in the Dask API during creation and review on those PRs, and if those things come up then we'll have the opportunity to change them.

And anyway, there are 4 other non-Dask issues you've said "definitely" should be fixed (#3872 (comment)) before the release, right?

StrikerRUS · 2021-02-16T12:16:44Z

@jameslamb

We might find some inconsistencies in the Dask API during creation and review on those PRs

I see, makes sense!

And anyway, there are 4 other non-Dask issues you've said "definitely" should be fixed (#3872 (comment)) before the release, right?

I said "I think" they should, because I cannot say just "they should" given that I'm not able to help fixing them 🙂 . So it's up to who is able to fix them decide whether they will or will not be in 3.2.0.

Anyway, it was just my curiosity why docs should block new release. Now I get it that writing docs may help spot API problems.

shiyu1994 · 2021-02-27T02:04:25Z

Hi @StrikerRUS and @jameslamb , thank you for the hard work. For the 3 bold core BUG's, #3761 is a numerical problem due to different computing strategy of col-wise and row-wise of LightGBM. And #3679 should have been fixed for the CPU version. We're waiting for response from #3778 for a reproducible example.

StrikerRUS · 2021-02-27T03:26:04Z

@shiyu1994

#3761 is a numerical problem due to different computing strategy of col-wise and row-wise of LightGBM

Can we have any workaround for this? If no, then I believe we should document that deterministic=true should be used together with either force_col_wise=true or force_row_wise=true. Otherwise, there is no guarantee of determinism.

shiyu1994 · 2021-02-27T03:27:54Z

@StrikerRUS Yes, I agree that we should document this in the description of deterministic parameter. I'll update the document.

StrikerRUS · 2021-02-27T12:53:05Z

@shiyu1994

And #3679 should have been fixed for the CPU version.

Then feel free to close that issue. For GPU version we have a separate open issue: #2793.

jameslamb · 2021-03-22T14:05:46Z

I just submitted 3.2.0 to CRAN, using the package generated by #3872 (comment).

@guolinke you should receive an email.

Please note that the submission is not completed until it is confirmed by the maintainer (via a link in the e-mail), who may need to check the spam folder.

I'll open a PR with the cran-comments.md file updates when we hear back from CRAN, and will upload the CRAN package to the release when we resolve #3872 (comment).

StrikerRUS · 2021-03-22T14:09:33Z

Changelog fixed now:

With new push to master release drafter will create new untagged draft release (3.2.1, it doesn't respect our VERSION.txt).

jameslamb · 2021-03-22T14:12:30Z

great, thanks! I just uploaded lightgbm-3.2.0-r-cran.tar.gz

StrikerRUS · 2021-03-22T14:15:32Z

I'll modify attached files with downloaded sources.

Hmm, I can't do that!

These files (Source code (zip) and Source code (tar.gz)) cannot be edited!

What should we do?..

StrikerRUS · 2021-03-22T14:17:28Z

Hmm, "nice"!..

My repo has a submodule, when i create a release, the tar/zip file generated doesn’t include the submodule.

This is not currently possible through GitHub.
https://github.community/t/create-release-that-contains-submodule/1329/2

StrikerRUS · 2021-03-22T14:40:43Z

What should we do?..

OK. I've uploaded correct files to the release (LightGBM-3.2.0-complete_source_code_zip.zip and LightGBM-3.2.0-complete_source_code_tar_gz.tar.gz). We should automate it, btw.

P.S. Now I know how to create .tar.gz in Windows: https://stackoverflow.com/questions/10773880/how-to-create-tar-gz-archive-file-in-windows#comment59759781_10773880 🤣

jameslamb · 2021-03-22T15:12:13Z

thanks for doing that!

StrikerRUS · 2021-03-22T15:12:52Z

PyPI release has been uploaded and tested.
Cool that embedded GPU-support is working!

StrikerRUS · 2021-03-22T15:32:18Z

@guolinke

Oh, I forget that. Would you like to take responsibility for the Nuget package? You can give me your username if yes.

OK, I can do that. Just registered account at NuGet: StrikerRUS

guolinke · 2021-03-23T02:27:14Z

@StrikerRUS @jameslamb Thank you so much!

@StrikerRUS had added you in Nuget.

jameslamb · 2021-03-23T02:31:19Z

it looks like {lightgbm} 3.2.0 has been accepted to CRAN!

https://cran.r-project.org/web/packages/lightgbm/index.html

but none of the CRAN checks have run yet (notice they are all 3.1.1)

https://cran.r-project.org/web/checks/check_results_lightgbm.html

I'll check back over the next few days and update cran-comments.md.

StrikerRUS · 2021-03-23T11:36:15Z

I hope I've done NuGet package publishing right. All I've done was clicking "Upload" section and choosing new .nupkg file from attachments of the release.

@guolinke Should we fix this warning for next release?

 We found the following issue(s):
The <licenseUrl> element is deprecated. Consider using the <license> element instead. Learn more.
We recommend that you fix these issues and upload a new package. Read more

UPD: Looks fine:

lostmygithubaccount · 2021-03-23T13:56:40Z

does homebrew need to be updated somehow? I'm still seeing 3.1.1:

StrikerRUS · 2021-03-23T15:19:08Z

@lostmygithubaccount

does homebrew need to be updated somehow?

Yes, refer to #3872 (comment) and Homebrew/homebrew-core#73665.

StrikerRUS · 2021-03-24T13:19:51Z

@jameslamb I don't remember r-devel-windows-x86_64-gcc10-UCRT CRAN flavor. Looks like something new, right?

https://www.r-project.org/nosvn/winutf8/ucrt3/CRAN/checks/gcc10-UCRT/README.txt

Luckily, we are passing checks there! 🙂

jameslamb · 2021-03-24T13:52:58Z

Yep! It's experimental.

StrikerRUS · 2021-03-24T14:42:57Z

Looks like it is fixing the following our issue:

Now, that test runs on all operating systems, but on Windows we expect the feature names in Booster$dump_model() to be changed.
#3647 (comment)

The main purpose of this toolchain is to allow UTF-8 as the
current native encoding on Windows, which would be a major step in fixing
most encoding problems R users encounter on Windows.

StrikerRUS · 2021-03-24T23:38:01Z

@guolinke @jameslamb @ankane
Seems that we have some problems with continuing to distribute LightGBM via Homebrew:
Homebrew/homebrew-core#73665 (comment).

* [docs]Add alt text on images * Update docs/GPU-Windows.rst Co-authored-by: James Lamb <jaylamb20@gmail.com> * Update docs/GPU-Windows.rst Co-authored-by: James Lamb <jaylamb20@gmail.com> * Apply suggestions from code review Co-authored-by: James Lamb <jaylamb20@gmail.com> * Apply suggestions from code review Co-authored-by: James Lamb <jaylamb20@gmail.com> * Merge main branch commit updates (#1) * [docs] Add alt text to image in Parameters-Tuning.rst (#4035) * [docs] Add alt text to image in Parameters-Tuning.rst Add alt text to Leaf-wise growth image, as part of #4028 * Update docs/Parameters-Tuning.rst Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: James Lamb <jaylamb20@gmail.com> * [ci] [R-package] upgrade to R 4.0.4 in CI (#4042) * [docs] update description of deterministic parameter (#4027) * update description of deterministic parameter to require using with force_row_wise or force_col_wise * Update include/LightGBM/config.h Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * update docs Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [dask] Include support for init_score (#3950) * include support for init_score * use dataframe from init_score and test difference with and without init_score in local model * revert refactoring * initial docs. test between distributed models with and without init_score * remove ranker from tests * test value for root node and change docs * comma * re-include parametrize * fix incorrect merge * use single init_score and the booster_ attribute * use np.float64 instead of float * [ci] ignore untitle Jupyter notebooks in .gitignore (#4047) * [ci] prevent getting incompatible dask and distributed versions (#4054) * [ci] prevent getting incompatible dask and distributed versions * Update .ci/test.sh Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * empty commit Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [ci] fix R CMD CHECK note about example timings (fixes #4049) (#4055) * [ci] fix R CMD CHECK note about example timings (fixes #4049) * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * empty commit Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [ci] add CMake + R 3.6 test back (fixes #3469) (#4053) * [ci] add CMake + R 3.6 test back (fixes #3469) * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * Update .ci/test_r_package_windows.ps1 * -Wait and remove rtools40 * empty commit Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [dask] include multiclass-classification task in tests (#4048) * include multiclass-classification task and task_to_model_factory dicts * define centers coordinates. flatten init_scores within each partition for multiclass-classification * include issue comment and fix linting error * Update index.rst (#4029) Add alt text to logo image Co-authored-by: James Lamb <jaylamb20@gmail.com> * [dask] raise more informative error for duplicates in 'machines' (fixes #4057) (#4059) * [dask] raise more informative error for duplicates in 'machines' * uncomment * avoid test failure * Revert "avoid test failure" This reverts commit 9442bdf. * [dask] add tutorial documentation (fixes #3814, fixes #3838) (#4030) * [dask] add tutorial documentation (fixes #3814, fixes #3838) * add notes on saving the model * quick start examples * add examples * fix timeouts in examples * remove notebook * fill out prediction section * table of contents * add line back * linting * isort * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * move examples under python-guide * remove unused pickle import Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * set 'pending' commit status for R Solaris optional workflow (#4061) * [docs] add Yu Shi to repo maintainers (#4060) * Update FAQ.rst * Update CODEOWNERS * set is_linear_ to false when it is absent from the model file (fix #3778) (#4056) * Add CMake option to enable sanitizers and build gtest (#3555) * Add CMake option to enable sanitizer * Set up gtest * Address reviewer's feedback * Address reviewer's feedback * Update CMakeLists.txt Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * added type hint (#4070) * [ci] run Dask examples on CI (#4064) * Update Parallel-Learning-Guide.rst * Update test.sh * fix path * address review comments * [python-package] add type hints on Booster.set_network() (#4068) * [python-package] add type hints on Booster.set_network() * change behavior * [python-package] Some mypy fixes (#3916) * Some mypy fixes * address James' comments * Re-introduce pass in empty classes * Update compat.py Remove extra lines * [dask] [ci] fix flaky network-setup test (#4071) * [tests][dask] simplify code in Dask tests (#4075) * simplify Dask tests code * enable CI * disable CI * Revert "[ci] prevent getting incompatible dask and distributed versions (#4054)" (#4076) This reverts commit 4e9c976. * Fix parsing of non-finite values (#3942) * Fix index out-of-range exception generated by BaggingHelper on small datasets. Prior to this change, the line "score_t threshold = tmp_gradients[top_k - 1];" would generate an exception, since tmp_gradients would be empty when the cnt input value to the function is zero. * Update goss.hpp * Update goss.hpp * Add API method LGBM_BoosterPredictForMats which runs prediction on a data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array) * Fix incorrect upstream merge * Add link to LightGBM.NET * Fix indenting to 2 spaces * Dummy edit to trigger CI * Dummy edit to trigger CI * remove duplicate functions from merge * Fix parsing of non-finite values. Current implementation silently returns zero when input string is "inf", "-inf", or "nan" when compiled with VS2017, so instead just explicitly check for these values and fail if there is no match. No attempt to optimise string allocations in this implementation since it is usually rarely invoked. * Dummy commit to trigger CI * Also handle -nan in double parsing method * Update include/LightGBM/utils/common.h Remove trailing whitespace to pass linting tests Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: matthew-peacock <matthew.peacock@whiteoakam.com> Co-authored-by: Guolin Ke <guolin.ke@outlook.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [dask] remove unused imports from typing (#4079) * Range check for DCG position discount lookup (#4069) * Add check to prevent out of index lookup in the position discount table. Add debug logging to report number of queries found in the data. * Change debug logging location so that we can print the data file name as well. * Revert "Change debug logging location so that we can print the data file name as well." This reverts commit 3981b34. * Add data file name to debug logging. * Move log line to a place where it is output even when query IDs are read from a separate file. * Also add the out-of-range check to rank metrics. * Perform check after number of queries is initialized. * Update * [ci] upgrade R CI scripts to work on Ubuntu 20.04 (#4084) * [ci] install additional LaTeX packages in R CI jobs * update autoconf version * bump upper limit on package size to 100 * [SWIG] Add streaming data support + cpp tests (#3997) * [feature] Add ChunkedArray to SWIG * Add ChunkedArray * Add ChunkedArray_API_extensions.i * Add SWIG class wrappers * Address some review comments * Fix linting issues * Move test to tests/test_ChunkedArray_manually.cpp * Add test note * Move ChunkedArray to include/LightGBM/utils/ * Declare more explicit types of ChunkedArray in the SWIG API. * Port ChunkedArray tests to googletest * Please C++ linter * Address StrikerRUS' review comments * Update SWIG doc & disable ChunkedArray<int64_t> * Use CHECK_EQ instead of assert * Change include order (linting) * Rename ChunkedArray -> chunked_array files * Change header guards * Address last comments from StrikerRUS * store all CMake files in one place (#4087) * v3.2.0 release (#3872) * Update VERSION.txt * update appveyor.yml and configure * fix Appveyor builds Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: StrikerRUS <nekit94-12@hotmail.com> * [ci] Bump version for development (#4094) * Update .appveyor.yml * Update cran-comments.md * Update VERSION.txt * update configure Co-authored-by: James Lamb <jaylamb20@gmail.com> * [ci] fix flaky Azure Pipelines jobs (#4095) * Update test.sh * Update setup.sh * Update .vsts-ci.yml * Update test.sh * Update setup.sh * Update .vsts-ci.yml * Update setup.sh * Update setup.sh Co-authored-by: Subham Agrawal <34346812+subhamagrawal7@users.noreply.github.com> Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: shiyu1994 <shiyu_k1994@qq.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: jmoralez <jmoralz92@gmail.com> Co-authored-by: marcelonieva7 <72712805+marcelonieva7@users.noreply.github.com> Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu> Co-authored-by: Deddy Jobson <dedjob@hotmail.com> Co-authored-by: Alberto Ferreira <AlbertoEAF@users.noreply.github.com> Co-authored-by: mjmckp <mjmckp@users.noreply.github.com> Co-authored-by: matthew-peacock <matthew.peacock@whiteoakam.com> Co-authored-by: Guolin Ke <guolin.ke@outlook.com> Co-authored-by: ashok-ponnuswami-msft <57648631+ashok-ponnuswami-msft@users.noreply.github.com> Co-authored-by: StrikerRUS <nekit94-12@hotmail.com> * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: Subham Agrawal <34346812+subhamagrawal7@users.noreply.github.com> Co-authored-by: shiyu1994 <shiyu_k1994@qq.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: jmoralez <jmoralz92@gmail.com> Co-authored-by: marcelonieva7 <72712805+marcelonieva7@users.noreply.github.com> Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu> Co-authored-by: Deddy Jobson <dedjob@hotmail.com> Co-authored-by: Alberto Ferreira <AlbertoEAF@users.noreply.github.com> Co-authored-by: mjmckp <mjmckp@users.noreply.github.com> Co-authored-by: matthew-peacock <matthew.peacock@whiteoakam.com> Co-authored-by: Guolin Ke <guolin.ke@outlook.com> Co-authored-by: ashok-ponnuswami-msft <57648631+ashok-ponnuswami-msft@users.noreply.github.com> Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>

ankane · 2021-03-25T12:25:35Z

Surprised it's an issue for header-only libraries. One approach I've seen other projects take is have a CMake flag to use system dependencies (for instance, LibTorch has -DUSE_SYSTEM_LIBS - https://github.com/pytorch/pytorch/blob/90bbe0b38bf5248a567bf4f8b7525612e06b641c/CMakeLists.txt#L343).

StrikerRUS · 2021-04-14T20:15:12Z

They just updated the formula: Homebrew/homebrew-core#73665 (review).

github-actions · 2023-08-23T22:50:34Z

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

Update VERSION.txt

0d7cdb2

guolinke requested review from jameslamb, Laurae2 and StrikerRUS as code owners January 28, 2021 02:17

jameslamb mentioned this pull request Jan 28, 2021

[dask] allow customization of num_threads #3714

Closed

StrikerRUS mentioned this pull request Jan 28, 2021

R-lintr failures at CI #3873

Closed

update appveyor.yml and configure

8f0bc3c

This was referenced Jan 28, 2021

[R-package] Add an R GPU job in CI #3780

Closed

[dask] DaskRegressor.predict() fails on DataFrame / Series input #3861

Closed

Trees with linear models at leaves #3299

Merged

jameslamb mentioned this pull request Feb 6, 2021

[dask] Add support for early stopping in Dask interface #3712

Closed

This was referenced Feb 9, 2021

[dask] [docs] Fix inaccuracies in API docs for Dask module (fixes #3871) #3930

Merged

[dask] tutorial documentation #3814

Closed

[docs] [dask] Document how to save a Dask model #3838

Closed

jameslamb mentioned this pull request Feb 16, 2021

[R-package] [docs] add intro vignette #3946

Merged

StrikerRUS mentioned this pull request Feb 19, 2021

linear_tree parameter not recognised by R version of LightGBM #4001

Closed

jameslamb mentioned this pull request Mar 24, 2021

[R-package] test on non-ASCII feature names fails on debian + clang CRAN check #4105

Closed

This was referenced Mar 26, 2021

[ci] attach archives with complete source code of the repo to releases #4111

Merged

[ci] build CRAN R-package on Azure with every commit and attach it to releases #4117

Merged

[docs] remove macOS installation method with Homebrew formula #4122

Merged

jameslamb mentioned this pull request Apr 9, 2021

v3.2.1 release #4169

Merged

17 tasks

StrikerRUS mentioned this pull request Apr 15, 2021

[docs] bring back macOS installation method with Homebrew formula in docs #4182

Merged

StrikerRUS mentioned this pull request Oct 10, 2021

Replace deprecated licenseUrl field with license one in .nuspec file #4669

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023

v3.2.0 release #3872

v3.2.0 release #3872

Conversation

guolinke commented Jan 28, 2021

jameslamb commented Jan 28, 2021 • edited

guolinke commented Jan 28, 2021

StrikerRUS commented Jan 28, 2021 • edited

Core

Java

R-package

GPU

CUDA

Important PRs submitted later than creating this list but nothing prevents them to be included in the release

StrikerRUS commented Jan 28, 2021 • edited

Release checklist:

shiyu1994 commented Jan 28, 2021

guolinke commented Feb 6, 2021

jameslamb commented Feb 7, 2021 • edited

StrikerRUS commented Feb 16, 2021

jameslamb commented Feb 16, 2021

StrikerRUS commented Feb 16, 2021

shiyu1994 commented Feb 27, 2021

StrikerRUS commented Feb 27, 2021

shiyu1994 commented Feb 27, 2021 • edited

StrikerRUS commented Feb 27, 2021

jameslamb commented Mar 22, 2021

StrikerRUS commented Mar 22, 2021

jameslamb commented Mar 22, 2021

StrikerRUS commented Mar 22, 2021

StrikerRUS commented Mar 22, 2021

StrikerRUS commented Mar 22, 2021 • edited

jameslamb commented Mar 22, 2021

StrikerRUS commented Mar 22, 2021 • edited

StrikerRUS commented Mar 22, 2021

guolinke commented Mar 23, 2021

jameslamb commented Mar 23, 2021

StrikerRUS commented Mar 23, 2021 • edited

lostmygithubaccount commented Mar 23, 2021

StrikerRUS commented Mar 23, 2021

StrikerRUS commented Mar 24, 2021

jameslamb commented Mar 24, 2021

StrikerRUS commented Mar 24, 2021

StrikerRUS commented Mar 24, 2021

ankane commented Mar 25, 2021

StrikerRUS commented Apr 14, 2021

github-actions bot commented Aug 23, 2023

jameslamb commented Jan 28, 2021 •

edited

StrikerRUS commented Jan 28, 2021 •

edited

StrikerRUS commented Jan 28, 2021 •

edited

jameslamb commented Feb 7, 2021 •

edited

shiyu1994 commented Feb 27, 2021 •

edited

StrikerRUS commented Mar 22, 2021 •

edited

StrikerRUS commented Mar 22, 2021 •

edited

StrikerRUS commented Mar 23, 2021 •

edited