[docs] update description of deterministic parameter #4027

shiyu1994 · 2021-03-01T02:10:59Z

Update the description of deterministic parameter. To guarantee that deterministic=true does produce stable results. We should also set force_col_wise=true or force_row_wise=true.

…orce_row_wise or force_col_wise

shiyu1994 · 2021-03-01T02:12:13Z

This PR should close issue #3761.

shiyu1994 · 2021-03-01T02:21:03Z

Required in #3872.

jameslamb · 2021-03-01T03:41:52Z

@shiyu1994 the CI failures look unrelated to these changes. I've documented them in #4031 and will submit a fix soon. Sorry for the inconvenience.

StrikerRUS

LGTM! Thank you! Just one typo.

StrikerRUS · 2021-03-01T13:32:35Z

docs/Parameters.rst

@@ -229,6 +229,8 @@ Core Parameters

   -  **Note**: setting this to ``true`` may slow down the training

+   -  **Note**: to avoid potential unstability due to numerical issues, please set ``force_col_wise=true`` or ``force_row_wise=true`` when setting ``deterministic=true``


Suggested change

- **Note**: to avoid potential unstability due to numerical issues, please set ``force_col_wise=true`` or ``force_row_wise=true`` when setting ``deterministic=true``

- **Note**: to avoid potential instability due to numerical issues, please set ``force_col_wise=true`` or ``force_row_wise=true`` when setting ``deterministic=true``

include/LightGBM/config.h

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

jameslamb · 2021-03-02T16:18:21Z

@shiyu1994 if you merge in the latest master, the CI problems should now be fixed (#4032). Sorry for the inconvenience.

…ix-3761

… fix-3761

jameslamb · 2021-03-03T03:34:18Z

ugh I'm sorry, so many CI problems this week haha.

The failing R tests on Windows (https://github.com/microsoft/LightGBM/pull/4027/checks?check_run_id=2018832067) are also showing up on master (https://github.com/microsoft/LightGBM/runs/2018204127). This is the thing failing the build.

checking whether package 'lightgbm' can be installed ... WARNING
Found the following significant warnings:
Warning: package 'R6' was built under R version 4.0.4
See 'C:/tmp-r-cmd-check/lightgbm.Rcheck/00install.out' for details.

I'll submit a PR in a few minutes to fix it. Sorry!

…ix-3761

* [docs]Add alt text on images * Update docs/GPU-Windows.rst Co-authored-by: James Lamb <jaylamb20@gmail.com> * Update docs/GPU-Windows.rst Co-authored-by: James Lamb <jaylamb20@gmail.com> * Apply suggestions from code review Co-authored-by: James Lamb <jaylamb20@gmail.com> * Apply suggestions from code review Co-authored-by: James Lamb <jaylamb20@gmail.com> * Merge main branch commit updates (#1) * [docs] Add alt text to image in Parameters-Tuning.rst (#4035) * [docs] Add alt text to image in Parameters-Tuning.rst Add alt text to Leaf-wise growth image, as part of #4028 * Update docs/Parameters-Tuning.rst Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: James Lamb <jaylamb20@gmail.com> * [ci] [R-package] upgrade to R 4.0.4 in CI (#4042) * [docs] update description of deterministic parameter (#4027) * update description of deterministic parameter to require using with force_row_wise or force_col_wise * Update include/LightGBM/config.h Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * update docs Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [dask] Include support for init_score (#3950) * include support for init_score * use dataframe from init_score and test difference with and without init_score in local model * revert refactoring * initial docs. test between distributed models with and without init_score * remove ranker from tests * test value for root node and change docs * comma * re-include parametrize * fix incorrect merge * use single init_score and the booster_ attribute * use np.float64 instead of float * [ci] ignore untitle Jupyter notebooks in .gitignore (#4047) * [ci] prevent getting incompatible dask and distributed versions (#4054) * [ci] prevent getting incompatible dask and distributed versions * Update .ci/test.sh Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * empty commit Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [ci] fix R CMD CHECK note about example timings (fixes #4049) (#4055) * [ci] fix R CMD CHECK note about example timings (fixes #4049) * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * empty commit Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [ci] add CMake + R 3.6 test back (fixes #3469) (#4053) * [ci] add CMake + R 3.6 test back (fixes #3469) * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * Update .ci/test_r_package_windows.ps1 * -Wait and remove rtools40 * empty commit Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [dask] include multiclass-classification task in tests (#4048) * include multiclass-classification task and task_to_model_factory dicts * define centers coordinates. flatten init_scores within each partition for multiclass-classification * include issue comment and fix linting error * Update index.rst (#4029) Add alt text to logo image Co-authored-by: James Lamb <jaylamb20@gmail.com> * [dask] raise more informative error for duplicates in 'machines' (fixes #4057) (#4059) * [dask] raise more informative error for duplicates in 'machines' * uncomment * avoid test failure * Revert "avoid test failure" This reverts commit 9442bdf. * [dask] add tutorial documentation (fixes #3814, fixes #3838) (#4030) * [dask] add tutorial documentation (fixes #3814, fixes #3838) * add notes on saving the model * quick start examples * add examples * fix timeouts in examples * remove notebook * fill out prediction section * table of contents * add line back * linting * isort * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * move examples under python-guide * remove unused pickle import Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * set 'pending' commit status for R Solaris optional workflow (#4061) * [docs] add Yu Shi to repo maintainers (#4060) * Update FAQ.rst * Update CODEOWNERS * set is_linear_ to false when it is absent from the model file (fix #3778) (#4056) * Add CMake option to enable sanitizers and build gtest (#3555) * Add CMake option to enable sanitizer * Set up gtest * Address reviewer's feedback * Address reviewer's feedback * Update CMakeLists.txt Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * added type hint (#4070) * [ci] run Dask examples on CI (#4064) * Update Parallel-Learning-Guide.rst * Update test.sh * fix path * address review comments * [python-package] add type hints on Booster.set_network() (#4068) * [python-package] add type hints on Booster.set_network() * change behavior * [python-package] Some mypy fixes (#3916) * Some mypy fixes * address James' comments * Re-introduce pass in empty classes * Update compat.py Remove extra lines * [dask] [ci] fix flaky network-setup test (#4071) * [tests][dask] simplify code in Dask tests (#4075) * simplify Dask tests code * enable CI * disable CI * Revert "[ci] prevent getting incompatible dask and distributed versions (#4054)" (#4076) This reverts commit 4e9c976. * Fix parsing of non-finite values (#3942) * Fix index out-of-range exception generated by BaggingHelper on small datasets. Prior to this change, the line "score_t threshold = tmp_gradients[top_k - 1];" would generate an exception, since tmp_gradients would be empty when the cnt input value to the function is zero. * Update goss.hpp * Update goss.hpp * Add API method LGBM_BoosterPredictForMats which runs prediction on a data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array) * Fix incorrect upstream merge * Add link to LightGBM.NET * Fix indenting to 2 spaces * Dummy edit to trigger CI * Dummy edit to trigger CI * remove duplicate functions from merge * Fix parsing of non-finite values. Current implementation silently returns zero when input string is "inf", "-inf", or "nan" when compiled with VS2017, so instead just explicitly check for these values and fail if there is no match. No attempt to optimise string allocations in this implementation since it is usually rarely invoked. * Dummy commit to trigger CI * Also handle -nan in double parsing method * Update include/LightGBM/utils/common.h Remove trailing whitespace to pass linting tests Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: matthew-peacock <matthew.peacock@whiteoakam.com> Co-authored-by: Guolin Ke <guolin.ke@outlook.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> * [dask] remove unused imports from typing (#4079) * Range check for DCG position discount lookup (#4069) * Add check to prevent out of index lookup in the position discount table. Add debug logging to report number of queries found in the data. * Change debug logging location so that we can print the data file name as well. * Revert "Change debug logging location so that we can print the data file name as well." This reverts commit 3981b34. * Add data file name to debug logging. * Move log line to a place where it is output even when query IDs are read from a separate file. * Also add the out-of-range check to rank metrics. * Perform check after number of queries is initialized. * Update * [ci] upgrade R CI scripts to work on Ubuntu 20.04 (#4084) * [ci] install additional LaTeX packages in R CI jobs * update autoconf version * bump upper limit on package size to 100 * [SWIG] Add streaming data support + cpp tests (#3997) * [feature] Add ChunkedArray to SWIG * Add ChunkedArray * Add ChunkedArray_API_extensions.i * Add SWIG class wrappers * Address some review comments * Fix linting issues * Move test to tests/test_ChunkedArray_manually.cpp * Add test note * Move ChunkedArray to include/LightGBM/utils/ * Declare more explicit types of ChunkedArray in the SWIG API. * Port ChunkedArray tests to googletest * Please C++ linter * Address StrikerRUS' review comments * Update SWIG doc & disable ChunkedArray<int64_t> * Use CHECK_EQ instead of assert * Change include order (linting) * Rename ChunkedArray -> chunked_array files * Change header guards * Address last comments from StrikerRUS * store all CMake files in one place (#4087) * v3.2.0 release (#3872) * Update VERSION.txt * update appveyor.yml and configure * fix Appveyor builds Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: StrikerRUS <nekit94-12@hotmail.com> * [ci] Bump version for development (#4094) * Update .appveyor.yml * Update cran-comments.md * Update VERSION.txt * update configure Co-authored-by: James Lamb <jaylamb20@gmail.com> * [ci] fix flaky Azure Pipelines jobs (#4095) * Update test.sh * Update setup.sh * Update .vsts-ci.yml * Update test.sh * Update setup.sh * Update .vsts-ci.yml * Update setup.sh * Update setup.sh Co-authored-by: Subham Agrawal <34346812+subhamagrawal7@users.noreply.github.com> Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: shiyu1994 <shiyu_k1994@qq.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: jmoralez <jmoralz92@gmail.com> Co-authored-by: marcelonieva7 <72712805+marcelonieva7@users.noreply.github.com> Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu> Co-authored-by: Deddy Jobson <dedjob@hotmail.com> Co-authored-by: Alberto Ferreira <AlbertoEAF@users.noreply.github.com> Co-authored-by: mjmckp <mjmckp@users.noreply.github.com> Co-authored-by: matthew-peacock <matthew.peacock@whiteoakam.com> Co-authored-by: Guolin Ke <guolin.ke@outlook.com> Co-authored-by: ashok-ponnuswami-msft <57648631+ashok-ponnuswami-msft@users.noreply.github.com> Co-authored-by: StrikerRUS <nekit94-12@hotmail.com> * Apply suggestions from code review Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: James Lamb <jaylamb20@gmail.com> Co-authored-by: Subham Agrawal <34346812+subhamagrawal7@users.noreply.github.com> Co-authored-by: shiyu1994 <shiyu_k1994@qq.com> Co-authored-by: Nikita Titov <nekit94-08@mail.ru> Co-authored-by: jmoralez <jmoralz92@gmail.com> Co-authored-by: marcelonieva7 <72712805+marcelonieva7@users.noreply.github.com> Co-authored-by: Philip Hyunsu Cho <chohyu01@cs.washington.edu> Co-authored-by: Deddy Jobson <dedjob@hotmail.com> Co-authored-by: Alberto Ferreira <AlbertoEAF@users.noreply.github.com> Co-authored-by: mjmckp <mjmckp@users.noreply.github.com> Co-authored-by: matthew-peacock <matthew.peacock@whiteoakam.com> Co-authored-by: Guolin Ke <guolin.ke@outlook.com> Co-authored-by: ashok-ponnuswami-msft <57648631+ashok-ponnuswami-msft@users.noreply.github.com> Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>

shoaibpatel4u · 2022-08-29T01:17:24Z

I am trying to run LightGBM regressor from Synapse ML lib latest version. I am able to set the deterministic parameter but the 2 runs of my experiment produce different results. Hence I tried to set parameter force_col_wise but this does not seem to be available.

cluster details :
Databricks runtime: 10.4 LTS (includes Apache Spark 3.2.1, Scala 2.12)
synapse ML version: com.microsoft.azure:synapseml_2.12:0.10.0

attached is the image for reference which shows an error while setting force_col_wise.
Also, the model explain parameters does not list the parameters force_col_wise and force_row_wise.
could you please let me know how I could set this parameter.

Another question on the same library.
for library https://github.com/microsoft/LightGBM with version v3.3.2 there are no maven coordinates for Databricks installation.
found one here https://mvnrepository.com/artifact/com.microsoft.ml.lightgbm/lightgbmlib/3.3.210
but in reference it points to Synapse ML link https://github.com/microsoft/SynapseML.
does the SynapseML library use this latest version of LightGBM or this is a totally different implementation?

jameslamb · 2022-08-29T01:21:47Z

Thanks for using LightGBM!

In the future, please:

open new issues for questions and bug reports instead of commenting on old merged pull requests
include the text of logs and error messages, not screenshots
open one issue per question when the questions are unrelated to each other

could you please let me know how I could set this parameter?
...
does the SynapseML library use this latest version of LightGBM or this is a totally different implementation?

We do not maintain SynapseML. Please ask these questions at https://github.com/microsoft/SynapseML.

github-actions · 2023-08-19T03:23:55Z

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

update description of deterministic parameter to require using with f…

9d03ace

…orce_row_wise or force_col_wise

shiyu1994 requested review from btrotta, chivee, guolinke, jameslamb, Laurae2 and StrikerRUS as code owners March 1, 2021 02:11

jameslamb mentioned this pull request Mar 1, 2021

[dask] [ci] scikit-learn compatibility tests failing #4031

Closed

jameslamb added the doc label Mar 1, 2021

StrikerRUS approved these changes Mar 1, 2021

View reviewed changes

Update include/LightGBM/config.h

6722a55

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

jameslamb changed the title ~~[Docs] update description of deterministic parameter~~ [docs] update description of deterministic parameter Mar 1, 2021

shiyu1994 added 3 commits March 3, 2021 02:49

Merge branch 'master' of https://github.com/microsoft/LightGBM into f…

92f61ca

…ix-3761

Merge branch 'fix-3761' of https://github.com/shiyu1994/LightGBM into…

9cf6131

… fix-3761

update docs

341f5dd

jameslamb mentioned this pull request Mar 3, 2021

[ci] [R-package] upgrade to R 4.0.4 in CI #4042

Merged

Merge branch 'master' of https://github.com/microsoft/LightGBM into f…

0d18925

…ix-3761

StrikerRUS merged commit 19f3577 into microsoft:master Mar 4, 2021

StrikerRUS mentioned this pull request Mar 4, 2021

Non-deterministic even with "deterministic=True" "seed=0" and the same number of threads in LightGBM==3.1.1 #3761

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] update description of deterministic parameter #4027

[docs] update description of deterministic parameter #4027

shiyu1994 commented Mar 1, 2021

shiyu1994 commented Mar 1, 2021

shiyu1994 commented Mar 1, 2021

jameslamb commented Mar 1, 2021

StrikerRUS left a comment

StrikerRUS Mar 1, 2021

shiyu1994 Mar 1, 2021

jameslamb commented Mar 2, 2021

jameslamb commented Mar 3, 2021

shoaibpatel4u commented Aug 29, 2022

jameslamb commented Aug 29, 2022

github-actions bot commented Aug 19, 2023

		@@ -229,6 +229,8 @@ Core Parameters

		- Note: setting this to ``true`` may slow down the training

		- Note: to avoid potential unstability due to numerical issues, please set ``force_col_wise=true`` or ``force_row_wise=true`` when setting ``deterministic=true``

	- Note: to avoid potential unstability due to numerical issues, please set ``force_col_wise=true`` or ``force_row_wise=true`` when setting ``deterministic=true``
	- Note: to avoid potential instability due to numerical issues, please set ``force_col_wise=true`` or ``force_row_wise=true`` when setting ``deterministic=true``

[docs] update description of deterministic parameter #4027

[docs] update description of deterministic parameter #4027

Conversation

shiyu1994 commented Mar 1, 2021

shiyu1994 commented Mar 1, 2021

shiyu1994 commented Mar 1, 2021

jameslamb commented Mar 1, 2021

StrikerRUS left a comment

Choose a reason for hiding this comment

StrikerRUS Mar 1, 2021

Choose a reason for hiding this comment

shiyu1994 Mar 1, 2021

Choose a reason for hiding this comment

jameslamb commented Mar 2, 2021

jameslamb commented Mar 3, 2021

shoaibpatel4u commented Aug 29, 2022

jameslamb commented Aug 29, 2022

github-actions bot commented Aug 19, 2023