New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] [ci] Dask compatibility with Python 3.8 and Pandas 2.0 #6030
Comments
Link #6028, which fails the ci due to this. |
I prefer option 1. |
Thanks for opening this! It's helpful to include the exact text of any logs / error messages that lead to a conclusion like "Dask-core version 2022.12.1 is not compatible with latest pandas versions (>= 2.0)", instead of just links to CI. That way, this issue and discussion can be found by others facing the same problem. Especially since those links only last for a few days before CI services tend to delete the builds. Here's what I see:
This looks like exactly the issue I reported in
I think it's important to note that not all Python 3.8 jobs are failing. ❌ On #6028, only the
Other Python 3.8 jobs are succeeding: ✅ (Azure)
✅ (Azure)
✅ (Azure)
✅ (Azure)
I suspect that maybe there's an issue with the Such things do sometimes resolve themselves. I just re-triggered the one failing job on #6028 : https://github.com/microsoft/LightGBM/actions/runs/5820545736/job/15820939242?pr=6028. Let's see if if builds successfully. If not, then I'd support modifying these lines Lines 125 to 126 in 20975ba
To
To try to force I do not support dropping Python 3.8 support in LightGBM over this. |
@jameslamb. Good suggestions. It would be a perfect solution if we can have
|
Ah interesting! That's very helpful. I can do some investigation today and open up a PR trying different combinations. |
I've opened a PR. You may use that branch for the trials as well. #6032 |
oh great, thank you! |
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Description
Dask-core version 2022.12.1 is not compatible with latest pandas versions (>= 2.0). For example, the ci task fails with the combination of dask-core-2022.12.1 and pandas-2.0.3.
https://github.com/microsoft/LightGBM/actions/runs/5820545736/job/15787141680?pr=6028
To fix this issue, we want to upgrade dask to a newer version. This job runs with python 3.8. However, I did not figure out the way to install latest dask for Python 3.8, and the document of dask says that it supports only python 3.9, 3.10 and 3.11.
https://docs.dask.org/en/latest/develop.html#python-versions
Python 3.8 support for dask was drop in May 2023 https://docs.dask.org/en/stable/changelog.html#v2023-5-1
So it seems that we have two choices:
Would like to hear your opinions @jameslamb @jmoralez @guolinke @StrikerRUS
The text was updated successfully, but these errors were encountered: