New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API method LGBM_BoosterPredictForMats #2008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…datasets. Prior to this change, the line "score_t threshold = tmp_gradients[top_k - 1];" would generate an exception, since tmp_gradients would be empty when the cnt input value to the function is zero.
…data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array)
@mjmckp Sorry for the inconvenience, but please update the branch to pass CI checks. |
The failing test looks unrelated to these changes (some python error), how to trigger the CI run again? |
guolinke
reviewed
Mar 14, 2019
@StrikerRUS any ideas why the test failed? |
@guolinke Yeah! Refer to the conversation started from #2061 (review) |
guolinke
approved these changes
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API method
LGBM_BoosterPredictForMats
which runs prediction on a data set given as of array of pointers to rows (as opposed to existing methodLGBM_BoosterPredictForMat
which requires data given as contiguous array).This is added to allow evaluation on training and validation data sets without reformatting of data in LightGBM.Net (C# wrapper).
Also, added a link to LightGBM.NET C# wrapper.