Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API method LGBM_BoosterPredictForMats #2008

Merged
merged 13 commits into from Mar 25, 2019
Merged

Conversation

mjmckp
Copy link
Contributor

@mjmckp mjmckp commented Feb 12, 2019

Add API method LGBM_BoosterPredictForMats which runs prediction on a data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array).

This is added to allow evaluation on training and validation data sets without reformatting of data in LightGBM.Net (C# wrapper).

Also, added a link to LightGBM.NET C# wrapper.

matthew-peacock and others added 7 commits November 2, 2018 13:07
…datasets.

Prior to this change, the line "score_t threshold = tmp_gradients[top_k - 1];" would generate an exception, since tmp_gradients would be empty when the cnt input value to the function is zero.
…data set given as of array of pointers to rows (as opposed to existing method LGBM_BoosterPredictForMat which requires data given as contiguous array)
@StrikerRUS
Copy link
Collaborator

@mjmckp Sorry for the inconvenience, but please update the branch to pass CI checks.

@mjmckp
Copy link
Contributor Author

mjmckp commented Feb 18, 2019

The failing test looks unrelated to these changes (some python error), how to trigger the CI run again?

@StrikerRUS
Copy link
Collaborator

@mjmckp You are absolutely right! Sorry for the inconvenience with failing tests. We fixed CI tests in #2016. Unfortunately, simple re-running tests without fixed from the mentioned PR will not help, please update the branch to pass tests.

@guolinke
Copy link
Collaborator

@StrikerRUS any ideas why the test failed?

@StrikerRUS
Copy link
Collaborator

@guolinke Yeah! Refer to the conversation started from #2061 (review)

@guolinke guolinke merged commit 823fc03 into microsoft:master Mar 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants