Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated gitignore to ignore files created by local python installation #2061

Merged
merged 2 commits into from Mar 26, 2019

Conversation

jameslamb
Copy link
Collaborator

I followed the instructions for building the Python package, and found that some of the files and directories produced are not covered by .gitignore. Would like to propose adding them.

python-package/LICENSE
python-package/build_cpp/
python-package/compile/

# duplicate version file
python-package/lightgbm/VERSION.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose VERSION.txt here is from local Python install too and can be moved under the same section.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure that's fair. I can do that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Uggghhh! 410 Gone http error from Microsoft MPI tutorial...

@jameslamb
Copy link
Collaborator Author

ugh that's annoying. Should I try to find it and open another PR to fix the link? (assuming it moved and wasn't just totally removed)

@StrikerRUS
Copy link
Collaborator

Very often what is needed is just to wait (... and rerun the test :-) ). But I see 410 error for the first time!
Also, I'm not sure that there is a mirror for that blog post...

@jameslamb
Copy link
Collaborator Author

When I navigate to https://blogs.technet.microsoft.com/windowshpc/2015/02/02/how-to-compile-and-run-a-simple-ms-mpi-program/ I see this in my browser (I did not View Source, this is literal text being returned and not rendered):

image

@jameslamb
Copy link
Collaborator Author

Jamess-MacBook-Pro:LightGBM jlamb$ curl -i https://blogs.technet.microsoft.com/windowshpc/2015/02/02/how-to-compile-and-run-a-simple-ms-mpi-program/
HTTP/1.1 410 Gone
Accept-Ranges: bytes
Content-Type: text/html
ETag: "ebd0540fb44f9f92b5ca37917de3309b:1541630414.543567"
Last-Modified: Wed, 07 Nov 2018 22:40:14 GMT
Server: AkamaiNetStorage
Content-Length: 12273
Date: Thu, 21 Mar 2019 01:23:13 GMT
Connection: keep-alive

wild 😂

@StrikerRUS
Copy link
Collaborator

@StrikerRUS
Copy link
Collaborator

Moreover, http://research.microsoft.com/en-us/projects/mslr/ is 404 now.

@guolinke
Copy link
Collaborator

@StrikerRUS mslr is good now.
For msmpi tutorial, maybe we can use some video contents, such as https://www.youtube.com/watch?v=iqzXhp5TxUY ?

@StrikerRUS
Copy link
Collaborator

@guolinke Hmm, interesting option! The only disadvantage I see is that you cannot copy-paste a code from a video. But since the code in the tutorial was represented as a screenshot, I think it's OK to provide a video.

@jameslamb
Copy link
Collaborator Author

just rebased to master now that #2065 was merged (thanks again @StrikerRUS )

@StrikerRUS StrikerRUS merged commit 82f803b into microsoft:master Mar 26, 2019
@jameslamb jameslamb deleted the py_gitignore branch January 27, 2020 00:15
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants