[python] added plot_split_value_histogram function #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
commented
Mar 9, 2019
python-package/lightgbm/plotting.py
Outdated
| xlim = (bins[0] - range_result * 0.2, bins[-1] + range_result * 0.2) | ||
| ax.set_xlim(xlim) | ||
|
|
||
| ax.set_yticks([int(tick) for tick in ax.get_yticks()]) |
There was a problem hiding this comment.
Is there any matplotlib expert here? 😃
I'm not sure how to do this properly.
There was a problem hiding this comment.
ping @henry0312 @chivee
There was a problem hiding this comment.
Seems that ax.yaxis.set_major_locator(MaxNLocator(integer=True)) is right way to do it.
https://stackoverflow.com/a/34880501
https://stackoverflow.com/a/11417609
https://stackoverflow.com/a/38096332
https://www.scivision.dev/matplotlib-force-integer-labeling-of-axis/
guolinke
approved these changes
Mar 14, 2019
Merged
|
@henry0312 can you review this PR? thanks! |
|
Sure, but I'm on a trip now, so I'll review in two days 🙋♂️
2019年4月30日(火) 23:19 Guolin Ke <notifications@github.com>:
@henry0312 <https://github.com/henry0312> can you review this PR? thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2043 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADJ2GQJEPUO6J7KBOX7F3LPTBINJANCNFSM4G43U53Q>
.
--
Tsukasa OMOTO
tomoto@if-el.se
|
henry0312
approved these changes
May 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.