Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0 realese #2138

Merged
merged 4 commits into from Sep 29, 2019
Merged

v2.3.0 realese #2138

merged 4 commits into from Sep 29, 2019

Conversation

guolinke
Copy link
Collaborator

@StrikerRUS @Laurae2 @jameslamb @henry0312
Which PRs should be included in this release ?

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Apr 30, 2019

@guolinke Yeah, just wanted to create an issue about new release. You're reading my thoughts! 😄

I'd like to include:

Also it's will be cool to fix issue

before new release.

P.S. Please check recent messages in Slack channel.

@jameslamb
Copy link
Collaborator

LGTM. I have nothing to add for this release beyond what @StrikerRUS has noted

@Laurae2
Copy link
Contributor

Laurae2 commented May 8, 2019

@guolinke We can also include #2159 in 2.2.4 as it fixes a major bug in the best score returned by the LightGBM booster.

@chivee
Copy link
Collaborator

chivee commented Jun 20, 2019

adding a reference to #2190.

@StrikerRUS
Copy link
Collaborator

I think we have a lot of new features, behavior changes, etc. to label new release as 2.3.0. WDYT guys?

@guolinke
Copy link
Collaborator Author

@StrikerRUS sure, could you make the change?

@StrikerRUS StrikerRUS changed the title v2.2.4 realese v2.3.0 realese Aug 17, 2019
@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Aug 17, 2019

Also, I'd like to merge

before the release. It's ready and awaiting second reviewer.

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Sep 10, 2019

I guess the main reason of such long delay #2209 is almost ready. Can we try to review and merge the following PRs before new release as well?

@jayantsahewal
Copy link

Is there a tentative target date for this release? There are a few critical bugs which have been fixed and merged in master months ago but haven't been released yet.

@guolinke
Copy link
Collaborator Author

@jayantsahewal sorry, we will move fast for the rest PRs.
@StrikerRUS let us target it before 1 OCT?

@StrikerRUS
Copy link
Collaborator

@guolinke Sure! Let's try!

Please don't forget to add a Git tag v2.3.0 in order to trigger changelog generation:

LightGBM/.vsts-ci.yml

Lines 170 to 172 in 7b2963d

- task: GitHubRelease@0
displayName: 'Create GitHub Release'
condition: and(succeeded(), startsWith(variables['Build.SourceBranch'], 'refs/tags/v'))

@StrikerRUS
Copy link
Collaborator

Wow, all blocking PRs have been merged! 🎉

@guolinke
Copy link
Collaborator Author

I will create a release soon.

@guolinke guolinke merged commit b3c1266 into master Sep 29, 2019
@guolinke guolinke deleted the new-release branch September 29, 2019 04:11
@jayantsahewal
Copy link

You guys rock! Thank you so much for getting this release out!!

@StrikerRUS
Copy link
Collaborator

@jayantsahewal Thank you and all users for your patience! We are very sorry about the long delay with this release.

@StrikerRUS
Copy link
Collaborator

@ankane Sorry for bothering you! Can you please help us to bump the version of LightGBM in Homebrew for the first time? Their docs say that brew should be used for that. But what if I have no macOS? Can I simply edit url and sha256 fields manually?

@ankane
Copy link
Contributor

ankane commented Sep 29, 2019

@StrikerRUS You can edit it manually and submit a PR. The brew command is just a shortcut for it.

@ankane
Copy link
Contributor

ankane commented Sep 29, 2019

@StrikerRUS
Copy link
Collaborator

@ankane Thanks! I've created: Homebrew/homebrew-core#44685.

@ankane
Copy link
Contributor

ankane commented Sep 29, 2019

Looks great. I think something is wrong with the Homebrew build system (some PRs haven't been built from 5 days ago), so there may be some delay.

@chris-smith-zocdoc
Copy link
Contributor

Should there have been a corresponding java release (lightgbmlib) with this @guolinke ? The latest I see on maven.org is 2.2.400 from August https://search.maven.org/search?q=g:com.microsoft.ml.lightgbm

@StrikerRUS
Copy link
Collaborator

@chris-smith-zocdoc We released JAR files here in our repo: https://github.com/microsoft/LightGBM/releases/tag/v2.3.0. For maven update, ping @imatiach-msft .

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants