Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][SWIG] fixed SWIG -Wstrict-aliasing warnings #2139

Merged
merged 2 commits into from May 4, 2019
Merged

[ci][SWIG] fixed SWIG -Wstrict-aliasing warnings #2139

merged 2 commits into from May 4, 2019

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #1556.

Clang is OK too:

Log (clickable)
-- The C compiler identification is Clang 7.1.0
-- The CXX compiler identification is Clang 7.1.0
-- Check for working C compiler: /usr/bin/clang
-- Check for working C compiler: /usr/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/clang++
-- Check for working CXX compiler: /usr/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found SWIG: /usr/local/bin/swig (found version "3.0.12") 
-- Found Java: /usr/lib/jvm/java-8-openjdk-amd64/bin/java (found version "1.8.0_171") 
-- Found JNI: /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/libjawt.so  
-- Found OpenMP_C: -fopenmp=libomp (found version "3.1") 
-- Found OpenMP_CXX: -fopenmp=libomp (found version "3.1") 
-- Found OpenMP: TRUE (found version "3.1")  
CMake Deprecation Warning at /usr/local/share/cmake-3.14/Modules/UseSWIG.cmake:559 (message):
  SWIG_ADD_MODULE is deprecated.  Use SWIG_ADD_LIBRARY instead.
Call Stack (most recent call first):
  CMakeLists.txt:186 (swig_add_module)


CMake Warning (dev) at /usr/local/share/cmake-3.14/Modules/UseSWIG.cmake:600 (message):
  Policy CMP0078 is not set: UseSWIG generates standard target names.  Run
  "cmake --help-policy CMP0078" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

Call Stack (most recent call first):
  /usr/local/share/cmake-3.14/Modules/UseSWIG.cmake:560 (swig_add_library)
  CMakeLists.txt:186 (swig_add_module)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at /usr/local/share/cmake-3.14/Modules/UseSWIG.cmake:460 (message):
  Policy CMP0086 is not set: UseSWIG honors SWIG_MODULE_NAME via -module
  flag.  Run "cmake --help-policy CMP0086" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.

Call Stack (most recent call first):
  /usr/local/share/cmake-3.14/Modules/UseSWIG.cmake:695 (SWIG_ADD_SOURCE_TO_MODULE)
  /usr/local/share/cmake-3.14/Modules/UseSWIG.cmake:560 (swig_add_library)
  CMakeLists.txt:186 (swig_add_module)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring done
-- Generating done
-- Build files have been written to: /__w/1/s/build
Scanning dependencies of target _lightgbm_swig_swig_compilation
[  1%] Swig compile swig/lightgbmlib.i for java
Scanning dependencies of target lightgbm
Scanning dependencies of target _lightgbm
[  3%] Building CXX object CMakeFiles/_lightgbm.dir/src/c_api.cpp.o
[  4%] Building CXX object CMakeFiles/lightgbm.dir/src/main.cpp.o
[  6%] Building CXX object CMakeFiles/lightgbm.dir/src/application/application.cpp.o
[  6%] Built target _lightgbm_swig_swig_compilation
[  7%] Building CXX object CMakeFiles/_lightgbm.dir/src/lightgbm_R.cpp.o
[  9%] Building CXX object CMakeFiles/lightgbm.dir/src/boosting/boosting.cpp.o
[ 10%] Building CXX object CMakeFiles/_lightgbm.dir/src/application/application.cpp.o
[ 12%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/boosting.cpp.o
[ 13%] Building CXX object CMakeFiles/lightgbm.dir/src/boosting/gbdt.cpp.o
[ 15%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt.cpp.o
[ 16%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt_model_text.cpp.o
[ 18%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/gbdt_prediction.cpp.o
[ 19%] Building CXX object CMakeFiles/lightgbm.dir/src/boosting/gbdt_model_text.cpp.o
[ 21%] Building CXX object CMakeFiles/lightgbm.dir/src/boosting/gbdt_prediction.cpp.o
[ 22%] Building CXX object CMakeFiles/_lightgbm.dir/src/boosting/prediction_early_stop.cpp.o
[ 24%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/bin.cpp.o
[ 25%] Building CXX object CMakeFiles/lightgbm.dir/src/boosting/prediction_early_stop.cpp.o
[ 27%] Building CXX object CMakeFiles/lightgbm.dir/src/io/bin.cpp.o
[ 28%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/config.cpp.o
[ 30%] Building CXX object CMakeFiles/lightgbm.dir/src/io/config.cpp.o
[ 31%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/config_auto.cpp.o
[ 33%] Building CXX object CMakeFiles/lightgbm.dir/src/io/config_auto.cpp.o
[ 34%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/dataset.cpp.o
[ 36%] Building CXX object CMakeFiles/lightgbm.dir/src/io/dataset.cpp.o
[ 37%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/dataset_loader.cpp.o
[ 39%] Building CXX object CMakeFiles/lightgbm.dir/src/io/dataset_loader.cpp.o
[ 40%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/file_io.cpp.o
[ 42%] Building CXX object CMakeFiles/lightgbm.dir/src/io/file_io.cpp.o
[ 43%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/json11.cpp.o
[ 45%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/metadata.cpp.o
[ 46%] Building CXX object CMakeFiles/lightgbm.dir/src/io/json11.cpp.o
[ 48%] Building CXX object CMakeFiles/lightgbm.dir/src/io/metadata.cpp.o
[ 50%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/parser.cpp.o
[ 51%] Building CXX object CMakeFiles/_lightgbm.dir/src/io/tree.cpp.o
[ 53%] Building CXX object CMakeFiles/lightgbm.dir/src/io/parser.cpp.o
[ 54%] Building CXX object CMakeFiles/lightgbm.dir/src/io/tree.cpp.o
[ 56%] Building CXX object CMakeFiles/_lightgbm.dir/src/metric/dcg_calculator.cpp.o
[ 57%] Building CXX object CMakeFiles/lightgbm.dir/src/metric/dcg_calculator.cpp.o
[ 59%] Building CXX object CMakeFiles/_lightgbm.dir/src/metric/metric.cpp.o
[ 60%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linker_topo.cpp.o
[ 62%] Building CXX object CMakeFiles/lightgbm.dir/src/metric/metric.cpp.o
[ 63%] Building CXX object CMakeFiles/lightgbm.dir/src/network/linker_topo.cpp.o
[ 65%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linkers_mpi.cpp.o
[ 66%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/linkers_socket.cpp.o
[ 68%] Building CXX object CMakeFiles/lightgbm.dir/src/network/linkers_mpi.cpp.o
[ 69%] Building CXX object CMakeFiles/lightgbm.dir/src/network/linkers_socket.cpp.o
[ 71%] Building CXX object CMakeFiles/_lightgbm.dir/src/network/network.cpp.o
[ 72%] Building CXX object CMakeFiles/_lightgbm.dir/src/objective/objective_function.cpp.o
[ 74%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/data_parallel_tree_learner.cpp.o
[ 75%] Building CXX object CMakeFiles/lightgbm.dir/src/network/network.cpp.o
[ 77%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/feature_parallel_tree_learner.cpp.o
[ 78%] Building CXX object CMakeFiles/lightgbm.dir/src/objective/objective_function.cpp.o
[ 80%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/gpu_tree_learner.cpp.o
[ 81%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/serial_tree_learner.cpp.o
[ 83%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/tree_learner.cpp.o
[ 84%] Building CXX object CMakeFiles/_lightgbm.dir/src/treelearner/voting_parallel_tree_learner.cpp.o
[ 86%] Building CXX object CMakeFiles/lightgbm.dir/src/treelearner/data_parallel_tree_learner.cpp.o
[ 87%] Building CXX object CMakeFiles/lightgbm.dir/src/treelearner/feature_parallel_tree_learner.cpp.o
[ 89%] Linking CXX shared library ../lib_lightgbm.so
[ 89%] Built target _lightgbm
Scanning dependencies of target _lightgbm_swig
[ 90%] Building CXX object CMakeFiles/_lightgbm_swig.dir/java/lightgbmlibJAVA_wrap.cxx.o
[ 92%] Building CXX object CMakeFiles/lightgbm.dir/src/treelearner/gpu_tree_learner.cpp.o
[ 93%] Building CXX object CMakeFiles/lightgbm.dir/src/treelearner/serial_tree_learner.cpp.o
[ 95%] Building CXX object CMakeFiles/lightgbm.dir/src/treelearner/tree_learner.cpp.o
[ 96%] Building CXX object CMakeFiles/lightgbm.dir/src/treelearner/voting_parallel_tree_learner.cpp.o
[ 98%] Linking CXX shared module ../lib_lightgbm_swig.so
[ 98%] Built target _lightgbm_swig
[100%] Linking CXX executable ../lightgbm
[100%] Built target lightgbm

@imatiach-msft Please review.

Copy link
Contributor

@imatiach-msft imatiach-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imatiach-msft
Copy link
Contributor

@StrikerRUS signed off, thanks for fixing this!

@StrikerRUS StrikerRUS mentioned this pull request Apr 30, 2019
@StrikerRUS StrikerRUS closed this May 4, 2019
@StrikerRUS StrikerRUS reopened this May 4, 2019
@StrikerRUS StrikerRUS merged commit b40d0dc into master May 4, 2019
@StrikerRUS StrikerRUS deleted the swig branch May 4, 2019 22:19
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix SWIG version -Wstrict-aliasing warnings
3 participants