-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests][python][scikit-learn] New unit tests and maintenance #3253
[tests][python][scikit-learn] New unit tests and maintenance #3253
Conversation
Update master
* Includes multioutput tests * Includes RandomizedSearchCV test * Updates dataset parameters to eliminate FutureWarning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-wozniakowski Thank you very much for fixing the FutureWarning and adding more tests! Given that scikit-learn public API changes in a non-backward compatible way (#2628) quite often and passing their check_estimator
test doesn't mean that we are fully compatible with the most recent API (scikit-learn/scikit-learn#15392 (comment)), I believe that having more tests for their popular tools is very important!
Please check some minor comment below:
* Also updates validation split in grid and random search
@StrikerRUS thanks for your feedback! I implemented the requested changes, and I wrote the grid/random searches such that there is an explicit train/validation/test split. Also, scikit-learn supports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for addressing comments! Please consider two check simplifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @a-wozniakowski !
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This pull request: