Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minimal CMake version #3501

Merged
merged 1 commit into from
Oct 30, 2020
Merged

bump minimal CMake version #3501

merged 1 commit into from
Oct 30, 2020

Conversation

StrikerRUS
Copy link
Collaborator

@StrikerRUS StrikerRUS commented Oct 29, 2020

According to the following discussion: #3405 (comment).

CMake < 3 is very-very old (in terms of their frequent releases). With 3.0 it will be possible to check API docs easier at least (docs for < 3 are hiddedn deep at their site and not structured).

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about the possible impact, so I don't think my review should count as a ❌ or ✅

But I do want to add for other reviewers that, specifically, cmake 3.0.0 was released in December 2018: https://github.com/Kitware/CMake/releases/tag/v3.0.0

@StrikerRUS
Copy link
Collaborator Author

@jameslamb

But I do want to add for other reviewers that, specifically, cmake 3.0.0 was released in December 2018: https://github.com/Kitware/CMake/releases/tag/v3.0.0

Oh, please don't be confused by that info! Actually, CMake 3.0.0 was released June 10, 2014: https://blog.kitware.com/cmake-3-0-0-available-for-download/.

Seems the thing is that Kitware created their helper bot kwrobot in December 2018 and it pushed all old releases of CMake in one day from their main GitLab repo.
https://github.com/Kitware/CMake/releases?after=v3.11.0

image

image

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants