Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] apply cpplint to cpp tests #4092

Merged
merged 6 commits into from
Mar 28, 2021
Merged

[ci] apply cpplint to cpp tests #4092

merged 6 commits into from
Mar 28, 2021

Conversation

StrikerRUS
Copy link
Collaborator

No description provided.

@StrikerRUS
Copy link
Collaborator Author

Only one issue left:

tests/cpp_test/test_chunked_array.cpp:42:  Is this a non-const reference? If so, make const or use a pointer: ChunkedArray<int> &ca  [runtime/references] [2]

Please help fix it.

@StrikerRUS StrikerRUS marked this pull request as ready for review March 22, 2021 12:45
@StrikerRUS StrikerRUS mentioned this pull request Mar 22, 2021
Merged
@StrikerRUS
Copy link
Collaborator Author

@AlbertoEAF Could you please help with this #4092 (comment) when have time?
You can checkout cpplint branch and make PR against it.

@AlbertoEAF AlbertoEAF mentioned this pull request Mar 27, 2021
Merged
@AlbertoEAF
Update test_chunked_array to please cpplint (#4121)
ad5dfc9 
* Update test_chunked_array to please cpplint

* Simplify var name

* Add comment
@StrikerRUS
Copy link
Collaborator Author

Thanks to @AlbertoEAF , this PR is ready for review.

jameslamb
jameslamb approved these changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, and I agree with applying cpplint to the tests in tests/cpp_test.

@StrikerRUS StrikerRUS merged commit 7bf81f8 into master Mar 28, 2021
@StrikerRUS StrikerRUS deleted the cpplint branch March 28, 2021 12:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@Laurae2 Laurae2 Awaiting requested review from Laurae2

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@StrikerRUS @jameslamb @AlbertoEAF