Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] added f-strings to python-package/lightgbm/engine.py #4258

Merged
merged 1 commit into from
May 5, 2021
Merged

[python] added f-strings to python-package/lightgbm/engine.py #4258

merged 1 commit into from
May 5, 2021

Conversation

kantajitshaw
Copy link
Contributor

@kantajitshaw kantajitshaw commented May 5, 2021 •
edited by jameslamb
Loading

Contributes to #4136.

@ghost
Copy link

ghost commented May 5, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

jameslamb
jameslamb approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for taking the time to contribute!

These changes look good to me. I quickly looked at engine.py and don't see any other places that need to be converted to f-strings.

Please see the edits I made to the pull request description. Whenever you open a pull request on GitHub, it's useful to mention any previous discussions that the pull request is related to. That helps maintainers to understand what you're trying to change and why they should consider accepting the changes.

@jameslamb jameslamb mentioned this pull request May 5, 2021
Closed
37 tasks
StrikerRUS
StrikerRUS approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@StrikerRUS StrikerRUS merged commit 11b7747 into microsoft:master May 5, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@chivee chivee Awaiting requested review from chivee

@henry0312 henry0312 Awaiting requested review from henry0312

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@wxchan wxchan Awaiting requested review from wxchan

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kantajitshaw @jameslamb @StrikerRUS