Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] improving the syntax of the fstring in the file : tests/python_package_test/test_basic.py #4312

Merged
merged 1 commit into from
May 21, 2021

Conversation

sayantan1410
Copy link
Contributor

I have made changes to seven lines in the file : tests/python_package_test/test_basic.py.
I am contributing to #4136
@jameslamb

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sayantan1410
Copy link
Contributor Author

Thanks for building such a cool community :) @StrikerRUS

@jameslamb
Copy link
Collaborator

Thanks for your help @sayantan1410 !

@jameslamb jameslamb merged commit da3465c into microsoft:master May 21, 2021
@sayantan1410 sayantan1410 deleted the fstring_improvement branch June 7, 2021 02:42
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants