Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [R-package] increase timeout on valgrind job #4397

Closed
wants to merge 2 commits into from

Conversation

jameslamb
Copy link
Collaborator

See #4391 (comment) and this failed job with a timeout of 180 minutes (https://github.com/microsoft/LightGBM/actions/runs/959047226).

It seems recently-added R package tests (or maybe some combination of that and changes in the C++ side) has led to the valgrind jobs exceeding 120 minutes. As a reminder, R runs substantially slower under valgrind (https://cran.r-project.org/doc/manuals/r-release/R-exts.html#Using-valgrind).

@jameslamb
Copy link
Collaborator Author

jameslamb commented Jun 22, 2021

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/959283121

Status: failure ❌.

@jameslamb jameslamb removed the request for review from StrikerRUS June 22, 2021 03:56
@jameslamb jameslamb marked this pull request as draft June 22, 2021 03:56
@jameslamb jameslamb changed the title WIP: [ci] [R-package] increase timeout on valgrind job [ci] [R-package] increase timeout on valgrind job Jun 23, 2021
@jameslamb jameslamb marked this pull request as ready for review June 23, 2021 04:19
@jameslamb
Copy link
Collaborator Author

This job is failing with an error message that suggests that the job config is being sourced from master, not this branch.

The job running on runner GitHub Actions 125 has exceeded the maximum execution time of 120 minutes.

https://github.com/microsoft/LightGBM/actions/runs/959283121

(notice that it says "120 minutes")

@StrikerRUS , does that mean this needs to be merged to be tested?

@StrikerRUS
Copy link
Collaborator

@jameslamb

does that mean this needs to be merged to be tested?

Yes, you're right.

on:
repository_dispatch:
types: [gha_run_r_valgrind]

With repository_dispatch event trigger, workflow config is taken from the default branch (master in our case).
https://docs.github.com/en/actions/reference/events-that-trigger-workflows#repository_dispatch

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@StrikerRUS
Copy link
Collaborator

Do you have rights to merge this PR with failing test?

@jameslamb
Copy link
Collaborator Author

It seems I don't have sufficient permissions to merge when a check is failing. Notice "squash and merge" is grayed out.

image

So I guess I'll have to open a new PR with these changes.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants