Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix deprecation numpy warning #4439

Merged
merged 1 commit into from
Jul 4, 2021
Merged

[tests] fix deprecation numpy warning #4439

merged 1 commit into from
Jul 4, 2021

Conversation

StrikerRUS
Copy link
Collaborator

  /__w/1/s/tests/python_package_test/test_basic.py:173: DeprecationWarning: `np.int` is a deprecated alias for the builtin `int`. To silence this warning, use `int` by itself. Doing this will not modify any behavior and is safe. When replacing `np.int`, you may wish to use e.g. `np.int64` or `np.int32` to specify the precision. If you wish to review your current use, check the release note link for additional information.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I checked for other instances of the deprecated aliases mentioned at https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations with git grep but couldn't find any.

@jameslamb jameslamb merged commit 29052c5 into master Jul 4, 2021
@jameslamb jameslamb deleted the numpy branch July 4, 2021 22:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants